Repo watchers

[williewheeler]

The repo watchers API needs to be elaborated in the way that I indicated over e-mail (need to be able to specify the desired page, and need to be able to find out how many pages there are). Also I'm thinking that the GitHub interface will become very large if people just add methods directly to it. Maybe that's fine.

[habuma]

I replied to your other emails before reading this one...but to repeat...

Have a look at...

• https://github.com/SpringSource/spring-social-twitter/blob/master/spring-social-twitter/src/main/java/org/springframework/social/twitter/api/Twitter.java
• https://github.com/SpringSource/spring-social-twitter/blob/master/spring-social-twitter/src/main/java/org/springframework/social/twitter/api/impl/TwitterTemplate.java

And notice how none of the API binding operations are defined in
Twitter/TwitterTemplate. Instead, the bigger API is broken down into
sub-APIs with their own sub-API binding. This was done for precisely the
reason you cite: To avoid having a big monster API binding implementation.

On 1/15/12 11:53 AM, Willie Wheeler wrote:

The repo watchers API needs to be elaborated in the way that I indicated over e-mail (need to be able to specify the desired page, and need to be able to find out how many pages there are). Also I'm thinking that the GitHub interface will become very large if people just add methods directly to it. Maybe that's fine.

You can merge this Pull Request by running:

git pull https://github.com/williewheeler/spring-social-github repo-watchers

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

• Added a collaborator endpoint and a basic watcher endpoint to GitHub and GitHubTemplate
• Added a collaborator endpoint and a basic watcher endpoint to GitHub and GitHubTemplate

-- File Changes --

M .gitignore (3)
M spring-social-github/src/main/java/org/springframework/social/github/api/GitHub.java (20)
A spring-social-github/src/main/java/org/springframework/social/github/api/GitHubUser.java (59)
M spring-social-github/src/main/java/org/springframework/social/github/api/impl/GitHubTemplate.java (64)

-- Patch Links --

https://github.com/SpringSource/spring-social-github/pull/1.patch
https://github.com/SpringSource/spring-social-github/pull/1.diff

---

Reply to this email directly or view it on GitHub:
#1

[habuma]

Forgot to mention: There are some guidelines for creating API bindings
in the reference documentation:
static.springsource.org/spring-social/docs/1.0.x/reference/html/implementing.html.

On 1/15/12 11:53 AM, Willie Wheeler wrote:

The repo watchers API needs to be elaborated in the way that I indicated over e-mail (need to be able to specify the desired page, and need to be able to find out how many pages there are). Also I'm thinking that the GitHub interface will become very large if people just add methods directly to it. Maybe that's fine.

You can merge this Pull Request by running:

git pull https://github.com/williewheeler/spring-social-github repo-watchers

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

• Added a collaborator endpoint and a basic watcher endpoint to GitHub and GitHubTemplate
• Added a collaborator endpoint and a basic watcher endpoint to GitHub and GitHubTemplate

-- File Changes --

M .gitignore (3)
M spring-social-github/src/main/java/org/springframework/social/github/api/GitHub.java (20)
A spring-social-github/src/main/java/org/springframework/social/github/api/GitHubUser.java (59)
M spring-social-github/src/main/java/org/springframework/social/github/api/impl/GitHubTemplate.java (64)

-- Patch Links --

https://github.com/SpringSource/spring-social-github/pull/1.patch
https://github.com/SpringSource/spring-social-github/pull/1.diff

---

Reply to this email directly or view it on GitHub:
#1

[williewheeler]

OK, will do. I'll rework the existing stuff to conform more to what you've
already established and resubmit.

Willie

On Sun, Jan 15, 2012 at 2:40 PM, Craig Walls <
reply@reply.github.com

wrote:

I replied to your other emails before reading this one...but to repeat...

Have a look at...

https://github.com/SpringSource/spring-social-twitter/blob/master/spring-social-twitter/src/main/java/org/springframework/social/twitter/api/Twitter.java
*
https://github.com/SpringSource/spring-social-twitter/blob/master/spring-social-twitter/src/main/java/org/springframework/social/twitter/api/impl/TwitterTemplate.java

And notice how none of the API binding operations are defined in
Twitter/TwitterTemplate. Instead, the bigger API is broken down into
sub-APIs with their own sub-API binding. This was done for precisely the
reason you cite: To avoid having a big monster API binding implementation.

On 1/15/12 11:53 AM, Willie Wheeler wrote:

The repo watchers API needs to be elaborated in the way that I indicated
over e-mail (need to be able to specify the desired page, and need to be
able to find out how many pages there are). Also I'm thinking that the
GitHub interface will become very large if people just add methods directly
to it. Maybe that's fine.

You can merge this Pull Request by running:

git pull https://github.com/williewheeler/spring-social-githubrepo-watchers

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

• Added a collaborator endpoint and a basic watcher endpoint to GitHub
  and GitHubTemplate
• Added a collaborator endpoint and a basic watcher endpoint to GitHub
  and GitHubTemplate

-- File Changes --

M .gitignore (3)
M
spring-social-github/src/main/java/org/springframework/social/github/api/GitHub.java
(20)
A
spring-social-github/src/main/java/org/springframework/social/github/api/GitHubUser.java
(59)
M
spring-social-github/src/main/java/org/springframework/social/github/api/impl/GitHubTemplate.java
(64)

-- Patch Links --

https://github.com/SpringSource/spring-social-github/pull/1.patch
https://github.com/SpringSource/spring-social-github/pull/1.diff

---

Reply to this email directly or view it on GitHub:
#1

---

Reply to this email directly or view it on GitHub:

#1 (comment)

[williewheeler]

Take a look at the refactoring to see if it's in the ballpark. Still need to do the test code. Will take a look at that, but first, Taco Bell.

[habuma]

Given a cursory glance (which is all I have time for today), I think you're on the right track. Note that I intend to move those other three methods in the GitHub interface out of that interface and into a sub-API interface soon; just haven't had much of a need to do that until now. But now that you've made things more interesting, they really need to move out of there. (But don't worry much about that...I'll take care of that myself).

[williewheeler]

Alright Craig, I added the tests. Should be good to go. Let me know if you see any issues.