Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Better error handling with ProviderSignInController #153

Closed
codelirium opened this issue Apr 22, 2015 · 2 comments
Closed

Better error handling with ProviderSignInController #153

codelirium opened this issue Apr 22, 2015 · 2 comments

Comments

@codelirium
Copy link
Contributor

The ProviderSignInController contains some handlers which can throw exceptions not handled properly.
For example: connectionFactoryLocator.getConnectionFactory(providerId) appears to be throwing an IllegalArgumentException which is not caught within the handler's scope to return provide the redirection url but rather gives back a shouty 500.
I will fork the repo soon and provide a pull request with a candidate solution.

@codelirium
Copy link
Contributor Author

Pull request for a fix @ #154

Kindest regards,
Stavros Lekkas (@codelirium)

habuma added a commit that referenced this issue May 6, 2015
@habuma
Copy link
Contributor

habuma commented May 6, 2015

Merged the PR and it should be available in the latest 1.1.1.BUILD-SNAPSHOT. Will produce a 1.1.1.RELEASE build soon.

@habuma habuma closed this as completed May 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants