Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimerTrigger not disarmed #321

Closed
jvalkeal opened this issue Feb 28, 2017 · 1 comment
Closed

TimerTrigger not disarmed #321

jvalkeal opened this issue Feb 28, 2017 · 1 comment
Labels
type/bug Is a bug report
Milestone
1.2.3.RELEASE

Comments

@jvalkeal
Copy link
Contributor

It looks like when machine is stopped then TimerTrigger is not stopped which effectively keeps it armed and trigger will fire causing new queued events to get spooled in a DefaultStateMachineExecutor.
@jvalkeal jvalkeal added the type/bug Is a bug report label Feb 28, 2017
@jvalkeal jvalkeal added this to the 1.2.3.RELEASE milestone Feb 28, 2017
@jvalkeal jvalkeal mentioned this issue Feb 28, 2017
Open
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Mar 8, 2017
@jvalkeal
Disarm timers
61a7905 
- Trying to handle scenario where TimerTrigger keeps firing
  even if machine is stopped or has moved away from its
  hosting state.
- Explicitely handle trigger starts/stops in
  DefaultStateMachineExecutor when executor itself
  is started/stopped.
- Fixes spring-projects#321
@jvalkeal jvalkeal mentioned this issue Mar 8, 2017
Merged
@jvalkeal
Copy link
Contributor Author

jvalkeal commented Mar 8, 2017

merged per 61a7905

@jvalkeal jvalkeal closed this as completed Mar 8, 2017
@jvalkeal jvalkeal mentioned this issue Mar 8, 2017
Closed
23 tasks
jvalkeal added a commit that referenced this issue Mar 9, 2017
@jvalkeal
Disarm timers
6ced037 
- Trying to handle scenario where TimerTrigger keeps firing
  even if machine is stopped or has moved away from its
  hosting state.
- Explicitely handle trigger starts/stops in
  DefaultStateMachineExecutor when executor itself
  is started/stopped.
- Backport #321
- Relates to #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Is a bug report
Projects
None yet
Milestone
1.2.3.RELEASE
Development

No branches or pull requests
1 participant
@jvalkeal