Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started and Dependencies #20

Closed
rwinch opened this issue Oct 26, 2016 · 2 comments
Closed

Getting Started and Dependencies #20

rwinch opened this issue Oct 26, 2016 · 2 comments
Milestone

Comments

@rwinch
Copy link
Member

rwinch commented Oct 26, 2016

The current Getting Started documentation states the dependencies necessary are:

<dependencies>

  <!-- other dependency elements omitted -->

  <dependency>
    <groupId>org.springframework.vault</groupId>
    <artifactId>spring-vault-core</artifactId>
    <version>{version}</version>
  </dependency>

</dependencies>

I found that in order to run the simple application, I need the following:

<dependencies>
    <dependency>
        <groupId>org.springframework.vault</groupId>
        <artifactId>spring-vault-core</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-beans</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-web</artifactId>
    </dependency>
    <dependency>
        <groupId>com.fasterxml.jackson.core</groupId>
        <artifactId>jackson-databind</artifactId>
    </dependency>
    <dependency>
        <groupId>commons-logging</groupId>
        <artifactId>commons-logging</artifactId>
        <version>1.2</version>
    </dependency>
</dependencies>

It might be nice to bring in these dependencies transitively. If not, then it would at least be nice to include the necessary jars in the docs

@rwinch rwinch changed the title Dependenc Getting Started and Dependencies Oct 26, 2016
@mp911de
Copy link
Member

mp911de commented Oct 26, 2016

Not quite sure why these dependencies weren't pulled in transitively as they are compile scoped. I suspect the mentioned milestone repo as it worked with Gradle/Maven once the Snapshots repo got referenced.

@rwinch
Copy link
Member Author

rwinch commented Oct 26, 2016

@mp911de It looks like forcing an update on the SNAPSHOT repository (I was already using the SNAPSHOT and thus the SNAPSHOT repo) fixed it for me. I'm not sure how I got a bad version cached locally. Thanks

@rwinch rwinch closed this as completed Oct 26, 2016
@mp911de mp911de modified the milestone: 1.0.0 M1 Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants