Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLF4J vs commons-logging? #24

Closed
rwinch opened this issue Oct 26, 2016 · 1 comment
Closed

SLF4J vs commons-logging? #24

rwinch opened this issue Oct 26, 2016 · 1 comment
Milestone
1.0.0 M1

Comments

@rwinch
Copy link
Member

rwinch commented Oct 26, 2016

Is it intentional to use SLF4J as apposed to commons-logging (as Spring Framework does)? If it is, this doesn't seem ideal given the framework uses commons-logging. We should probably also update the dependencies for #20 to have slf4j an implementation and switch to jcl-over-slf4j
@mp911de
Copy link
Member

mp911de commented Oct 26, 2016

We used SLF4J in Spring Cloud Vault and so it was retained. Spring Vault isn't very demanding regarding logging so aligning with Spring Framework by using commons-logging seems like natural fit.

@mp911de mp911de added this to the 1.0.0 M1 milestone Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0 M1
Development

No branches or pull requests
2 participants
@rwinch @mp911de