Fix namespace prefix handling with StreamingPayload #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getName() method in JaxbStreamingPayload doesn't report the actual namespace prefix that is later generated by the writeTo method. With Axiom 1.2.13 that didn't cause problems, but 1.2.14 is less lenient, causing an error as described in AXIOM-463. This change: * Updates the StreamingPayload documentation to specify that the namespace prefix in the QName returned by getName() has no significance (which is effectively how things are currently). * Updates AxiomSoapBody so that it Axiom is aware that the namespace prefix of the created OMSourcedElement is unknown. * Modifies the unit test for setStreamingPayload so that it uses a StreamingPayload with a prefix mismatch.
|
@veithen I've walked through this PR. I ran it as well as the master branch, both against Axiom 1.2.13 and 1.2.14. I don't see any breaking change to expose the issue at hand. Is there an additional test case we need to expose the fault you are citing? |
|
The PR generalizes an existing test case to expose the problem. If you only apply the part of the change that modifies AbstractSoapMessageTestCase, then you can reproduce the failure. |
|
Thanks. I can poke at this some more next week. |
|
Still getting this error any update when this PR can be released? I have support with VMware/pivotal if you need me to report it that channel to help get it bumped in priority. |
|
Resolved via 1d9a6b5. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getName() method in JaxbStreamingPayload doesn't report the actual
namespace prefix that is later generated by the writeTo method. With
Axiom 1.2.13 that didn't cause problems, but 1.2.14 is less lenient,
causing an error as described in AXIOM-463.
This change:
namespace prefix in the QName returned by getName() has no significance
(which is effectively how things are currently).
prefix of the created OMSourcedElement is unknown.
StreamingPayload with a prefix mismatch.