This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
[Sprint: 58] XD-3358: Fix Job Deployment with Module Count=0 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
force-pushed
the
XD-3358
branch
from
57a941a
to
daf58d0
Compare
|
Re-pushed with version bump to 1.3.0.BUILD-SNAPSHOT. |
JIRA: https://jira.spring.io/browse/XD-3358 Javascript test for '' and 0 both evaluate to false. Initialize the variable to 'undefined' and test for that condition.
garyrussell
force-pushed
the
XD-3358
branch
from
daf58d0
to
a58ef91
Compare
|
LGTM - Merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/XD-3358
Javascript test for '' and 0 both evaluate to false.
Initialize the variable to 'unspecified' and test for that value.