[Sprint: 42] XD-2690 - Filter lib files other than .zip and .jar #1442
Conversation
|
|
||
| public static final String DOT_JAR = ".jar"; | ||
|
|
||
| public static final String DOT_ZIP = ".zip"; |
There was a problem hiding this comment.
why even accept .zip? We won't add them to the CP currently
There was a problem hiding this comment.
.zip is a legitimate extension for a CP element. See http://docs.oracle.com/javase/7/docs/technotes/tools/windows/classpath.html. I don't see what we could possibly gain by not accepting them.
@ericbottard can you clarify the second part of the comment: org.springframework.xd.module.support.ModuleUtils#createModuleClassLoader(org.springframework.core.io.Resource, java.lang.ClassLoader, boolean) doesn't seem to do any filtering of archives of its own.
There was a problem hiding this comment.
My bad, I was under the impression we only looked up .jar
So yeah, we shall accept .zip
The more, the merrier...
There was a problem hiding this comment.
OK :) I'll LGTM it, and add it to the merge pipeline.
sabbyanandan
changed the title
|
Merged w/97aa52a |
No description provided.