This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
[Sprint: 46] XD-2854 Migrate Stream definitions that don't have MDs #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This code checks for existing stream definitions and update the module definitions if they don't exist. - Add better exception handling - Use PostConstruct to run migration
sabbyanandan
changed the title
| CuratorFramework client = this.zkConnection.getClient(); | ||
| if (client.checkExists().forPath(Paths.STREAMS) != null) { | ||
| Iterable<StreamDefinition> streamDefinitions = findAll(); | ||
| for (StreamDefinition definition : streamDefinitions) { |
There was a problem hiding this comment.
These two lines can be simplified to:
for (StreamDefinition definition : findAll()) {
|
Squashed & merged as 0d18468 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the module definitions if they don't exist.