This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
[Sprint: 47] XD-2911 - Improved performance of Tuple Creation #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors how the conversion service used within a Tuple is created to a more performant option. Prior to this commit, for each instance of TupleBuilder created (and under typical usage, each Tuple) an instance of DefaultTupleConversionService was created. This updated version changes the default to be a static instance and changes the recommended approach for customization to be a ConfigurableConversionService be configured as a singleton within your module's context and then used across all Tuple instances. This provides better performance in the creation of Tuples.
|
I will merge as is with the performance tests but I would like to move them into spring-xd-benchmark as soon as #1558 which introduces that project is merged. This is intended to provide similar tests and separate them from the normal build. |
|
rebased and merged |
sabbyanandan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE - This is a breaking change.
This commit refactors how the conversion service used within a Tuple is
created to a more performant option. Prior to this commit, for each
instance of TupleBuilder created (and under typical usage, each Tuple)
an instance of DefaultTupleConversionService was created. This updated
version changes the default to be a static instance and changes the
recommended approach for customization to be a
ConfigurableConversionService be configured as a singleton within your
module's context and then used across all Tuple instances. This
provides better performance in the creation of Tuples.