This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial code drop for parser alternative. See https://jira.springsource.org/browse/XD-196
More work to be done as DSL language firms up and needs more work on error handling. This merge also contains tests (and fixes) for:
https://jira.springsource.org/browse/XD-159 "improve module parameter parsing"
And the the most recent comments by Jen/Gary in https://github.com/SpringSource/spring-xd/issues/1
Effectively these all work now:
A key change with this patch is that argument/parameter values with spaces in must be quoted.
Currently it tolerates the
tap @foo
syntax and does exactly as the old parser, converts it under the covers totap --channel=foo.0