Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix to remove unnecessary @Autowired appears twice #1106

Closed
martinlippert opened this issue Sep 5, 2023 · 5 comments
Closed

quick fix to remove unnecessary @Autowired appears twice #1106

martinlippert opened this issue Sep 5, 2023 · 5 comments
Assignees

Comments

@martinlippert
Copy link
Member

I have a simple Rest Service guide project created and added an @Autowired constructor to the GreetingController. It is flagged with a warning, but invoking the quick fix popup, the remove unnecessary @Autowired appears twice.

@martinlippert
Copy link
Member Author

This has a timing component to it. If you invoke the quick fixes quickly after the warning appears, there is only one quick fix showing up. But invoking the quick fix popup again, you will see the second quick fix appearing.

@martinlippert
Copy link
Member Author

The same happens for the validation / quick fix that flags unnecessary public modifiers for @Bean methods, where all three quick fixes (remove, remove in file, remove in project) appear twice as well in the quick fix popup.

@BoykoAlex
Copy link
Contributor

@martinlippert can you paste the screenshot of the popup? It's not the hover and not the dialog you get when invoken quick fix from the problems view... It is the shell that pops up when you click on an icon in the gutter, correct?

@martinlippert
Copy link
Member Author

I hit Cmd-1 from within the editor with the cursor placed at the first character of the annotation

@BoykoAlex
Copy link
Contributor

Fixed with e79da39, unit tested with 2a397ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants