Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide preference to open code lens URLs in simple browser #1207

Closed
martinlippert opened this issue Mar 13, 2024 · 4 comments
Closed

provide preference to open code lens URLs in simple browser #1207

martinlippert opened this issue Mar 13, 2024 · 4 comments
Assignees
Labels
for: vscode something that is specific for VSCode theme: live-data type: enhancement

Comments

@martinlippert
Copy link
Member

Add a preference to choose where to open URLs from code lenses. At the moment, the browser from your operating system is launched externally to show the URL. The spring dashboard in VSCode opens the URLs of request mappings in a Simple Browser in VSCode directly.

We should add a preference to allow users to define where to open these URLs (from code lenses) and add the option to open them in a simple browser inside of VSCode.

@BoykoAlex
Copy link
Contributor

CodeLenses is the tip of the iceberg... I have implemented the setting for CodeLenses but there are other means of opening requst mappings URLs via symbols and hovers. Not sure how to deal with symbols at all yet... The hovers seem to support a link that executes a command but looks like this is in VSCode only... Seems more difficult than i was hoping for ;-)

@martinlippert
Copy link
Member Author

I don't think we need to align everything here. If we directly control the "open browser" activity, let's use the preference to allow users to choose between the external and the internal simple browser. If we do not control the action to open a browser, let's not invest a lot of time into working around that.

@BoykoAlex
Copy link
Contributor

CodeLens support is in with 63a99ba.
I'd like to look into links from hovers a bit more...

@BoykoAlex
Copy link
Contributor

VSCode hovers are also supported via 1883ceb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: vscode something that is specific for VSCode theme: live-data type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants