Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show a nice message when trying to change log levels without a connected running app #1232

Closed
martinlippert opened this issue Apr 17, 2024 · 4 comments
Closed

show a nice message when trying to change log levels without a connected running app #1232

martinlippert opened this issue Apr 17, 2024 · 4 comments
Assignees
@BoykoAlex
Labels
for: vscode something that is specific for VSCode theme: live-data type: enhancement
Milestone
4.22.1.RELEASE

Comments

@martinlippert
Copy link
Member

If there is no live data or connection for live data for a running Spring Boot app around, the command to change log levels shows up just empty. It is understandable that there is no quick pick list showing up (since there is no launched app), but it would be nice to let the user know that this is the case, maybe via some greyed out message in the text field.
@martinlippert martinlippert added type: enhancement theme: live-data for: vscode something that is specific for VSCode labels Apr 17, 2024
@martinlippert martinlippert added this to the 4.22.1.RELEASE milestone Apr 17, 2024
@BoykoAlex
Copy link
Contributor

Fixed with cb9c438

@BoykoAlex
Copy link
Contributor

BoykoAlex commented Apr 17, 2024 •
edited

I've decided to popup the info message and hide the quick pick. However, we can leave the quick pick open and have the title of the quickpick showing "No running Spring Boot Apps Found" or have both: the quickpick still showing and the info message popup... Or just the quickpick showing....
The greyed out text in the quickpick is the placeholder... o ne can type in there, once something is typed the placeholder text is gone hence i'd not use that.

@BoykoAlex
Copy link
Contributor

This should show the same message in log levels UI: 9b60d60

@martinlippert
Copy link
Member Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
for: vscode something that is specific for VSCode theme: live-data type: enhancement
Projects
None yet
Milestone
4.22.1.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex