Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut to dashboard #876

Merged
merged 2 commits into from Nov 9, 2022
Merged

Conversation

Eskibear
Copy link
Contributor

@Eskibear Eskibear commented Nov 9, 2022

VS Code now recommends boot-dev-pack for spring developers. Here to add a shortcut to dashboard for exposure.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Contributor Author

Eskibear commented Nov 9, 2022

Comparison as below.

image

@martinlippert As VS Code rolls out the recommendation, there will be a number of users following it to install boot-dev-pack, and they will see this walkthrough, probably only once (immediately after installing the pack). It's a good chance for them to discover the dashboard. So I want to add the entry before they see the walkthrough. Would you mind helping to ship an update includes this PR?

@martinlippert
Copy link
Member

Makes all a lot of sense to me. The only minor improvement that I have in mind here is that the text blurb doesn't say anything about the dashboard and therefore the button feels a bit disconnected from my perspective. I would add one more sentence at the end of the text blurb, saying something like "Some of the symbols are also shown as part of the Spring Boot Dashboard perspective, like all your Spring bean definitions and Spring MVC request mappings." - then have the button. It feels to me more like a natural flow when reading the walkthrough and then click the button. WDYT?

@martinlippert martinlippert added this to the 4.17.0.RELEASE milestone Nov 9, 2022
@Eskibear
Copy link
Contributor Author

Eskibear commented Nov 9, 2022

Cannot agree more, I'll update the PR.

@martinlippert martinlippert merged commit 22b3733 into spring-projects:main Nov 9, 2022
@martinlippert
Copy link
Member

Awesome. Merged. Thanks for the contribution!!!

@Eskibear Eskibear deleted the walkthrough branch November 9, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: vscode something that is specific for VSCode type: documentation type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants