Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATEBATTLEINFO allows tab at the end #177

Closed
abma opened this issue Jun 25, 2015 · 5 comments
Closed

UPDATEBATTLEINFO allows tab at the end #177

abma opened this issue Jun 25, 2015 · 5 comments

Comments

@abma
Copy link
Contributor

abma commented Jun 25, 2015

UPDATEBATTLEINFO[space]3835[space]0[space]0[space]1481928328[space]Comet[space]Catcher[space]Redux[space]v2[TAB]

add check!

@abma abma added the bug label Jun 25, 2015
@ghost
Copy link

ghost commented Jun 25, 2015

another one
UPDATEBATTLEINFO[space]3846[space]0[space]0[space]1085734645[space]Moon[space]Quartet[space]Remake[TAB]

@ghost
Copy link

ghost commented Jun 25, 2015

Here's the full debug log, it's all because of the map name having a tab at the end (**EOL added for readability)

Something went wrong while receiving
E: BATTLEOPENED[S]3849[S]0[S]0[S]AndoPat[S]139.216.64.71[S]8452[S]32[S]1[S]0[S]1027531324[S]spring[T]94.1[T]Into[S]Battle_v3[T][T]adas[T]Metal[S]Factions[S]v0.7**EOL

Something went wrong while receiving
E: UPDATEBATTLEINFO[S]3849[S]0[S]0[S]1027531324[S]Into[S]Battle_v3[T]**EOL

I'm catching and logging them now, I won't be posting this anymore.
Thanks!

@abma
Copy link
Contributor Author

abma commented Jun 25, 2015

do all UPDATEBATTLEINFO & BATTLEOPENED commands have tab at the end? (didn't had the time yet to investigate this)

if so... it makes more sense to keep it but add more strict checking at server side.

@ghost
Copy link

ghost commented Jun 25, 2015

Nope, 98% of them don't, I believe this comes from the map filename in some way.

Here's how 'normal' looks (EOL added for readability):

UPDATEBATTLEINFO 3838 1 0 -182876094 Chicken_Farm_v02EOL
UPDATEBATTLEINFO 3447 1 0 -1993493856 Colorado_v1EOL
UPDATEBATTLEINFO 3687 1 0 -538795039 DesertTriadEOL
UPDATEBATTLEINFO 3688 1 0 -843447902 deserteagleEOL

BATTLEOPENED 3431 0 0 [durian]Autohost 78.46.100.156 8482 21 0 0 -1010508423 spring 98.0 Red Comet Durian (Flea Bowl) XTA test-955EOL

BATTLEOPENED 3689 0 0 [ACE]Pirine 78.193.134.82 8456 10 0 0 1290565381 spring 98.0 Dune [5 v 5] [ACE]=Army Corps of Engineers :P ('_^) Balanced Annihilation V8.17EOL

So it either happens with some lobby that doesn't send data right, or it's the map thing. I'm ignoring them now. It might be a source of bugs with downloading maps too.

@silentwings
Copy link
Contributor

silentwings commented Nov 25, 2018

afaics the only possible cause of this is that the map actually has a tab char at the end of its name, or the client is broken - either way, no sign of it anymore, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants