Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve channel history / remove channel subscription #183

Closed
abma opened this issue Sep 28, 2015 · 7 comments
Closed

improve channel history / remove channel subscription #183

abma opened this issue Sep 28, 2015 · 7 comments

Comments

@abma
Copy link
Contributor

abma commented Sep 28, 2015

-> let the lobby client sent what history it wants:

  • lobby server doesn't need to store a date
  • no gaps when client crashed / timed out

ideally by last msg id and not by time

@abma
Copy link
Contributor Author

abma commented Nov 18, 2015

historical data should contain timestamps (which are already in db, so the required change would be minor)

@gajop
Copy link
Member

gajop commented Nov 19, 2015

-> let the lobby client sent what history it wants:
+1, and ideally also allow the lobby to retrieve historical data that has already been sent (keep history).
This is pretty useful when switching PCs/lobbies without having to rely on local backups.

abma added a commit that referenced this issue Oct 3, 2017
@abma
Copy link
Contributor Author

abma commented Oct 3, 2017

todo:

  1. implement client side
  2. remove the old implementation (especially the check in SQLUsers.py / get_channel_history for subscription)
  3. remove subscription table / commands

@abma abma changed the title improve channel history / subscription improve channel history / remove channel subscription Oct 3, 2017
@silentwings
Copy link
Contributor

rel #312 #241

@abma

This comment has been minimized.

@silentwings

This comment has been minimized.

@silentwings
Copy link
Contributor

as far as i can see, all this has already been done

silentwings added a commit that referenced this issue Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants