Removed all dependencies on the Addressable gem

[dstotz]

This change allows the addressable gem to be removed from our Ruby client to avoid conflicts with other gems that rely on a newer version of addressable

---

This change is 

[dstotz]

Forgot to add one test and dropped coverage down. Adding the test now.

[coveralls]

Coverage remained the same at 100.0% when pulling d3f82e0 on dstotz:remove-addressable into 61a8a68 on springboardretail:master.

[jstotz]

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @dstotz)

---

lib/springboard/client/uri.rb, line 107 at r1 (raw file):

      end

      def normalized_query_hash_values(value)

This should probably be called normalize_query_value. The verb tense should match normalize_query_hash and it should be singular because it normalizes a single value.

---

spec/springboard/client_spec.rb, line 91 at r1 (raw file):

    end

    it "should return a resource object when given a path as asymbol" do

typo: "asymbol" -> "a symbol"

Also, this test and the one before it look like they're not super useful / corret. Test says "should return a resource object with the given path and client" but it's only checking the class.

---

spec/springboard/client/resource_spec.rb, line 320 at r1 (raw file):

    end

    describe 'normalize_uri' do

This is a private method and should not be tested directly. Make sure the behavior these tests exercise is part of the test for a public method and then just delete them.

---

spec/springboard/client/uri_spec.rb, line 117 at r1 (raw file):

    it "should support hash param values" do
      uri.__send__(:query_values=, {:a => {:b => {:c => 123}}})

This is a public method so you don't need to use __send__

---

spec/springboard/client/uri_spec.rb, line 127 at r1 (raw file):

    it "should return the current query values" do
      uri.query = 'sort[]=f1&sort[]=f2&per_page=all'
      uri.__send__(:query_values=, uri.query_values)

Same here

---

spec/springboard/client/uri_spec.rb, line 132 at r1 (raw file):

  end

  describe 'normalize_query_hash' do

Another private method that shouldn't be tested directly.

---

spec/springboard/client/uri_spec.rb, line 149 at r1 (raw file):

  end

  describe 'normalized_query_hash_values' do

Another private method that shouldn't be tested directly.

[jstotz]

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @dstotz)

---

lib/springboard/client/resource.rb, line 174 at r1 (raw file):

      # @return [Resource]
      def embed(*embeds)
        embeds = (query['_include[]'] || []) + embeds

Since you had to make this change, don't we have to make a similar change in Collection#filter? I don't like the asymmetry of writing as key and reading as key[]. Seems like it's just asking for bugs. Maybe we should strip off the [] when generating a hash in URI#query_values.

[dstotz]

Reviewable status: 2 of 7 files reviewed, 8 unresolved discussions (waiting on @jstotz and @dstotz)

---

lib/springboard/client/resource.rb, line 174 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

Since you had to make this change, don't we have to make a similar change in Collection#filter? I don't like the asymmetry of writing as key and reading as key[]. Seems like it's just asking for bugs. Maybe we should strip off the [] when generating a hash in URI#query_values.

Good call. I've made that change and fixed the tests.

---

lib/springboard/client/uri.rb, line 107 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

This should probably be called normalize_query_value. The verb tense should match normalize_query_hash and it should be singular because it normalizes a single value.

Done.

---

spec/springboard/client_spec.rb, line 91 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

typo: "asymbol" -> "a symbol"

Also, this test and the one before it look like they're not super useful / corret. Test says "should return a resource object with the given path and client" but it's only checking the class.

Done.

---

spec/springboard/client/resource_spec.rb, line 320 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

This is a private method and should not be tested directly. Make sure the behavior these tests exercise is part of the test for a public method and then just delete them.

I have moved tests for this behavior into the [] method on the client spec as that is when this method gets called

---

spec/springboard/client/uri_spec.rb, line 117 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

This is a public method so you don't need to use __send__

Done.

---

spec/springboard/client/uri_spec.rb, line 127 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

Same here

Done.

---

spec/springboard/client/uri_spec.rb, line 132 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

Another private method that shouldn't be tested directly.

Moved relevant tests to query_values= tests

---

spec/springboard/client/uri_spec.rb, line 149 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

Another private method that shouldn't be tested directly.

Moved relevant tests to query_values= tests

[jstotz]

Reviewed 5 of 5 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jstotz)

---

lib/springboard/client/uri.rb, line 107 at r1 (raw file):

Previously, dstotz (Derek Stotz) wrote…

Done.

Only partially addresses my suggestion

[dstotz]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jstotz)

---

lib/springboard/client/uri.rb, line 107 at r1 (raw file):

Previously, jstotz (Jay Stotz) wrote…

Only partially addresses my suggestion

Sorry about that, totally forgot to remove the d. Just pushed an update.

[jstotz]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved