Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No empty description for polymorphic subtypes #2371

Merged
merged 1 commit into from Oct 15, 2023
Merged

No empty description for polymorphic subtypes #2371

merged 1 commit into from Oct 15, 2023

Conversation

westse
Copy link
Contributor

@westse westse commented Sep 6, 2023

westse
westse commented Sep 6, 2023
View reviewed changes
...i-tests/springdoc-openapi-javadoc-tests/src/test/java/test/org/springdoc/api/app170/Cat.java
import io.swagger.v3.oas.annotations.media.Schema;

@Schema
public class Cat implements Animal {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice missing class Javadoc (and no explicit description set on @Schema), which should translate to null Schema.description

@westse westse marked this pull request as ready for review September 6, 2023 22:48
@westse westse mentioned this pull request Sep 6, 2023
Closed
@bnasslahsen
Copy link
Contributor

@westse,

Thank you for your contribution to the project.

@bnasslahsen bnasslahsen merged commit 5ec10ac into springdoc:main Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty schema description if polymorphic subtype missing Javadoc
2 participants
@westse @bnasslahsen