Respect schema annotations when using spring mvc with kotlin #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug when using kotlin and spring mvc. The field `noRequiredNoNullableDefault` in `springdoc-openapi-tests/springdoc-openapi-kotlin-mvc-tests/src/test/kotlin/test/org/springdoc/api/app9/DemoController.kt` will be marked as required when it should not, it has a default value in the swagger annotation. When adding `AnnotationIntrospectors`, the order matters. The fact that the `SpringDocJacksonKotlinModuleConfiguration` was dependent on `ObjectMapperProvider` and `SpringDocConfiguration` made it so that the `SpringDocRequiredModule` was added before the `KotlinModule`. To fix this bug we create a primary bean for the `ObjectMapperProvider` when `KotlinModule` is on the class path to ensure that this module is added before `SpringDocRequiredModule`. Tests are added for spring mvc using kotlin Co-authored-by: Ola Petersson <olbpetersson@gmail.com> Co-authored-by: Simon Lindhen <simon.lindhen@gmail.com>
|
@bnasslahsen do you think you will accept this PR for the next release? If not, is there something we can do to make that happen? |
|
i will add you PR for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when using kotlin and spring mvc. The field
noRequiredNoNullableDefaultinspringdoc-openapi-tests/springdoc-openapi-kotlin-mvc-tests/src/test/kotlin/test/org/springdoc/api/app9/DemoController.ktwill be marked as required when it should not, it has a default value in the swagger annotation.When adding
AnnotationIntrospectors, the order matters. The fact that theSpringDocJacksonKotlinModuleConfigurationwas dependent onObjectMapperProviderandSpringDocConfigurationmade it so that theSpringDocRequiredModulewas added before theKotlinModule.To fix this bug we create a primary bean for the
ObjectMapperProviderwhenKotlinModuleis on the class path to ensure that this module is added beforeSpringDocRequiredModule.Tests are added for spring mvc using kotlin
Co-authored-by: Ola Petersson olbpetersson@gmail.com
Co-authored-by: Simon Lindhen simon.lindhen@gmail.com