Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create accessibility checklist #63

Merged
merged 2 commits into from
Aug 9, 2016
Merged

create accessibility checklist #63

merged 2 commits into from
Aug 9, 2016

Conversation

dotcode
Copy link
Contributor

@dotcode dotcode commented Aug 9, 2016

No description provided.

@hollsk
Copy link
Contributor

hollsk commented Aug 9, 2016

Looks perfect. One link (to the effective colour contrast) points to an internal resource and should go somewhere open, though.

I'm hemming and hawing a bit as to whether we should recreate that internal resource here or not - we can't link to the source text anymore because it's linkrotted. On the one hand the information is really useful, but on the other hand it'd open the door to a massive accessibility guide. That in itself isn't a bad thing by any means, but is it in scope for this particular project?

@dotcode
Copy link
Contributor Author

dotcode commented Aug 9, 2016

Ooh, good catch.

<looks in vain for the "thinking-face" emoji />

Hmm. Yeah … I want to avoid creating an accessibility guide. The reason I created that page on the wiki was because it was just so useful. Illustrates the issue really well, seems right to ...

Right, so I've argued myself into recreating that page here. It's right that the information exists on the web, someone else might find it useful.

 ... add back in on completion of #64
@dotcode dotcode merged commit 39ed19e into master Aug 9, 2016
@dotcode dotcode deleted the accessibility-checklist branch August 9, 2016 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants