Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge window for tomorrow affecting today #608

Closed
wilsondw opened this issue Jan 11, 2024 · 2 comments
Closed

Charge window for tomorrow affecting today #608

wilsondw opened this issue Jan 11, 2024 · 2 comments
Assignees

Comments

@wilsondw
Copy link

Describe the bug
At approx 04:50, after charging to target SOC during cheap rate period, predbat switched to hold charging 82% and then to idle leaving the charge target at 82%. At the same time Predbat calculated and set a charge window (but did not set the charge target) for the next day extending to 8am (changed to 7am in a later run). As the charge slots are based on time only (not date), this inadvertently led to the inverter holding charge at 82% through to 7am when the plan was reporting idle. The future slot set by predbat appears as 'charge limit base' in the predbat plan with the 82% target from today's hold charging and at 100% target calculated by the plan as 'charge limit best'.

2024-01-11 04:45:11.968080 INFO pred_bat: Not setting charging SOC as we are not within the window (now 01-11 04:45:00 target set_soc_minutes 30 charge start time 01-11 04:00:00)
2024-01-11 04:45:11.972555 INFO pred_bat: Adjust reserve to target charge 82 % (set_reserve_enable is true)
2024-01-11 04:45:11.979126 INFO pred_bat: Inverter 0 Current reserve is 83.0 already at target
2024-01-11 04:45:12.025994 INFO pred_bat: Will not recompute the plan, it is 5.0 minutes old and max age is 10 minutes
2024-01-11 04:45:12.029619 INFO pred_bat: Completed run status Hold charging

2024-01-11 04:51:56.677774 INFO pred_bat: Charge window will be: 2024-01-12 02:00:00+00:00 - 2024-01-12 08:00:00+00:00 - current soc 82 target 100
2024-01-11 04:51:56.681767 INFO pred_bat: Configuring charge window now (now 01-11 04:50:00 target set_window_minutes 30 charge start time 01-12 02:00:00
2024-01-11 04:52:08.785443 INFO pred_bat: Inverter 0 set charge slot 1 {'start': '02:00', 'finish': '08:00'} via REST successful after retry 0
2024-01-11 04:52:08.856889 INFO pred_bat: Inverter 0 Updated start and end charge window to 02:00:00 - 08:00:00 (old 03:00:00 - 05:00:00)
2024-01-11 04:52:24.629364 INFO pred_bat: Set inverter 0 charge schedule True via REST successful on retry 0
2024-01-11 04:52:24.673358 INFO pred_bat: Inverter 0 Turning on scheduled charge
2024-01-11 04:52:24.688547 INFO pred_bat: Setting ECO mode as no discharge window planned
2024-01-11 04:52:24.700024 INFO pred_bat: Inverter 0 Adjust force discharge to False, change times from 00:00:00 - 00:00:00 to None - None
2024-01-11 04:52:24.709876 INFO pred_bat: Inverter 0 current discharge rate is 0 and new target is 3600
2024-01-11 04:52:34.138969 INFO pred_bat: Inverter 0 set discharge rate 3600 via REST successful on retry 0
2024-01-11 04:52:34.171466 INFO pred_bat: Not setting charging SOC as we are not within the window (now 01-11 04:50:00 target set_soc_minutes 30 charge start time 01-12 02:00:00)
2024-01-11 04:52:34.176292 INFO pred_bat: Adjust reserve to default (as set_reserve_enable is true)
2024-01-11 04:52:34.181505 INFO pred_bat: Inverter 0 Current Reserve is 83.0 % and new target is 4.0 %
2024-01-11 04:52:50.194960 INFO pred_bat: Set inverter 0 reserve 4 via REST successful on retry 0
2024-01-11 04:52:50.273540 INFO pred_bat: Completed run status Idle

Screenshot 2024-01-11 at 07 36 35

Expected behavior
Predat should probably have cleared the charge target when it switched from hold charging to idle and should probably not set future charge / discharge windows extending beyond 24hours in the future

Predbat version

7.14.36

Environment details

  • Gen 2 with 9.5kWh battery
  • Standard HAOS

Log file
appdaemon.log

Can you capture a log file from the time of the issue, debug mode is not normally required.
If you are not keeping the full logs then please enable this in appdaemon.yaml (see the installation instruction in the Predbat docs area for details on how to do this)

@springfall2008
Copy link
Owner

This does look like a real bug, I'll take a look

springfall2008 added a commit that referenced this issue Jan 12, 2024
* Fix time window wrap issue, predbat restore automation

#608

* [pre-commit.ci lite] apply automatic fixes

* Fix to state save code

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@springfall2008
Copy link
Owner

Fixed in latest release

springfall2008 added a commit that referenced this issue Feb 5, 2024
* Fix constant reset inverter issue with previous release (#526)

* Add 'main' to list of updates, catch some extra errors (#528)

* Cloud coverage PV fix (#529)

* Cloud coverage PV fix
* PV power prediction issues

* Cloud coverage pv fix (attempt 2) (#532)

#530

* Discharge optimisation (#533)

* Discharge optimisation

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Tweaks to optimisation to try to prevent locked in discharge (#538)

* Tweaks to optimisation to try to prevent locked in discharge

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Miscalculation of car charging window size (#544)

Possible fix for: #542

* Avoid resetting charge window when charge isn't enabled (#549)

* Avoid resetting charge window when charge isn't enabled

#545

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update video-guides.md (#550)

* Update video-guides.md

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update video-guides.md (#551)

* Update video-guides.md (#552)

* Update video-guides.md

* Template sofar inverter sensors (#524)

* Template sofar inverter sensors

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update video-guides.md (#555)

* Update video-guides.md

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Do not reset inverter in read-only mode even for mode (#557)

* Update README.md (#558)

* Update README.md

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update dynamic-entities-card.yaml (#559)

* Fix update selector showing blank (#562)

* Update to handling of update entity (#563)

* Fix to sanity check for apps_dir default (#564)

* Fix to sanity check for apps_dir default

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Car charging soc manual (#569)

* Car charging soc manual

#568
* Update customisation.md

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Predbat documentation enhancements (#570)

* Improved readability for new users
* Add Redownload
* Further tweaks
* Full unix pathnames
* Restructure & enhance to guide new users better
* Explain how to change the 'enforce basepath'  switch for File Editor add-on
* Explain how to stop Predbat joining & managing Octopus saving sessions
* Clarify Predbat mode settings required for saving sessions
* Expanded metric_min_improvement_discharge description for #530
* Restructure & enhance config-yml.md for readability
* Improve car charging description in apps.yaml
* Renamed config-yml-settings to apps-yaml & completed review & updates
* Merge in appdaemon-predbat add-on install instructions
* Add AppDaemon/Predbat combined add-on install method #566

---------

Co-authored-by: Trefor Southwell <48591903+springfall2008@users.noreply.github.com>

* Fix crash with calculate soc only (#573)

* Fix crash with calculate soc only

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix issue causing extra high slots to be used in charging (#579)

* Potential fixes for handling of NoCharge (#578)

* Potential fixes for handling of NoCharge

* Ensure charges are discarded if they are set to reserve
* Avoid selecting reserve if charge freeze is off
* Don't set reserve while charging if SOC is above target

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update predbat.py (#580)

* Do not set reserve while actively charging (#584)

* Don't reset charge window going read-only if not controlling it (#585)

* Don't reset charge window going read-only if not controlling it

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Documentation fixes: explain nordpool apps.yaml cfg, 'so solar data' FAQ, corrected menu structure (#581)

* Remove stray loom references

* Added 'no solar data' FAQ

* Added rounding to 'Rate min forward looking' log message

* Further reword to 'Rate min forward looking' msg

* Added explanation of nordpool future rates apps.yaml config.
Changed import adjust to True & export to False for #576

* Corrected menu structure for apps-yaml

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Potential fix for too many freeze charges (#587)

* Potential fix for too many freeze charges

#586

* [pre-commit.ci lite] apply automatic fixes

* Update predbat.py

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update predbat.py (#588)

* New calculation regions optimisation feature (#589)

* New calculation regions optimisation feature

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Calculate region feature (#591)

* Calculate region feature

Fix threshold value issue after region pass: #590

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Set calculate regions to be expert mode switch (#592)

* Set calculate regions to be expert mode switch

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Region optimisation tweaks (#593)

* Set calculate regions to be expert mode switch

* [pre-commit.ci lite] apply automatic fixes

* Update customisation.md

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix to avoid crash if car charging plan time is not set correctly (#594)

* Fix freeze charging appearing too often issue (#597)

* Fix freeze charging appearing too often issue

#595

* Apply same fix for freeze discharge

* Documentation enhancements (#596)

* Review and update configuration guide

* Review & refine 'what does predbat do'

* Update README.md (#599)

* Update README.md

* Update install.md

* Minor tweak to allow new installs not to get zero data (#603)

* Additional fix for missing load scenario (#604)

Prevent negative data during wrap of days previous

* Update video-guides.md (#606)

* Update video-guides.md

* [pre-commit.ci lite] apply automatic fixes

* Update custom-dictionary-workspace.txt

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update video-guides.md (#607)

* Fix to allow continued operation after REST error (#609)

* Fix time window wrap issue, predbat restore automation (#610)

* Fix time window wrap issue, predbat restore automation

#608

* [pre-commit.ci lite] apply automatic fixes

* Fix to state save code

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Change default metric battery cycle to 1.0 (#613)

* Change default metric battery cycle to 1.0

* [pre-commit.ci lite] apply automatic fixes

* Update customisation.md

* Update configuration-guide.md

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Account for time taken to calculate plan but reading inverter status again afterwards (#615)

* Account for time taken to calculate plan but reading inverter status again afterwards

* [pre-commit.ci lite] apply automatic fixes

* Update predbat.py

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Save/Restore settings selector function (#616)

* Save/Restore settings selector function
* Remove old save settings for automation code
* Update customisation.md - document save/restore

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update dynamic-entities-card.yaml (#618)

* Fix restore of previous.yaml (avoid overwriting itself) (#622)

* Fix restore of previous.yaml (avoid overwriting itself)

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix issue where inverter skew is falsely reported (#623)

* Fix issue where inverter skew is falsely reported

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix save/restore to not restore counters, fix bug in monitor mode where reserve was reset (#624)

* Fix save/restore to not restore counters, fix bug in monitor mode where reserve was reset
- Save/restore no longer restores holiday days left, iboost today or manual car SOC
- Do not reset reserve when in monitor mode


---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Override (#635)

* Manual charge override feature

* Finish off override function for charge & discharge

* [pre-commit.ci lite] apply automatic fixes

* Update predbat.py

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Documentation updates, givtcp activity monitor, further explanation of config items (#625)

* Review and update configuration guide

* Review & refine 'what does predbat do'

* Expand explanation days_previous with examples

* Added explanation of how set_reserve_min could be used to retain SOC ahead of predicted storms #571

* Add explanation of using car_charging_energy to filter other loads such as Mixergy out #574

* Add details of load_forecast and predheat Not utilising battery #574

* Added 'choose' branching to givtcp activity monitor

* Added givtcp alert if inverter temperature <5 degrees (should never happen, indicates inverter offline)

* Added GivTCP restart to activity monitor

* Move GivTCP 'output raw register values' image into images folder

* Move 'Predbat sample data-out dashboard' into images folder

* Added rounding to rate_min_forward_looking log message

* Reformat 'joined Octopus saving session' log & alert for improved readability

* [pre-commit.ci lite] apply automatic fixes

* Expanded and updated Predbat Plan card documentation

* Line length fix

* Minor changes to predbat-plan-card

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix bug in monitor mode changing charge window (#636)

* Fix bug in monitor mode changing charge window

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix bug in car charging smart calculation (#637)

* Fix bug in car charging smart calculation

#621

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Add manual idle time, fix bug in manual mode related to 60 minute slots (#638)

* Add manual idle time, fix bug in manual mode related to 60 minute slots

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update customisation.md (#639)

* Update customisation.md

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* New saving session scaling feature (#640)

* New saving session scaling feature
* Load scaling in manual rates overrides
* Change manual override to 18 hours


---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* fixes to manual override mode (#641)

* fixes to manual override mode

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update car-charge-planning.md (#642)

* Update car-charge-planning.md

* Update car-charge-planning.md

* Optimisation to speed up first pass levelling (#651)

* Optimisation to speed up first pass levelling

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix issue with charge rate being reset when it shouldn't be in low power mode (#652)

* Fix issue with charge rate being reset when it shouldn't be in low power mode

Maybe related to:

#650


---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Reduce low power margin to 10 minutes (#653)

* Reduce low power margin to 10 minutes

#650

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Low power charging, more accurate setting and some debug (#654)

* Low power charging, more accurate setting and some debug

#650

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update customisation.md - car charging hold docs (#655)

* Update customisation.md

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix battery charge curve modelling for lower than max battery charge rate setting (#657)

* Fix battery charge curve modelling for lower than max battery charge rate settings


---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Find charge curve code (#658)

* Find charge curve code

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Tidy up battery power curve calculations/reporting (#659)

* Tidy up battery power curve calculations/reporting
* Update apps.yaml

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update apps-yaml.md (#660)

* Update apps-yaml.md

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix crash with .replace in battery power curve code (#663)

* Fix crash with .replace in battery power curve code

* Update apps.yaml - change number to sensor

* Async fetch history to avoid timeouts (#665)

* Async fetch history to avoid timeouts

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Issue with reserve max causing flip/flop charging at 100% (#668)

* Issue with reserve max causing flip/flop charging at 100%

#667


---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Documentation updates: Monitor mode, Battery loss & scaling, new FAQ for impoving the plan, days_previous (#670)

* Review and update configuration guide

* Review & refine 'what does predbat do'

* Expand explanation days_previous with examples

* Added explanation of how set_reserve_min could be used to retain SOC ahead of predicted storms #571

* Add explanation of using car_charging_energy to filter other loads such as Mixergy out #574

* Add details of load_forecast and predheat Not utilising battery #574

* Added 'choose' branching to givtcp activity monitor

* Added givtcp alert if inverter temperature <5 degrees (should never happen, indicates inverter offline)

* Added GivTCP restart to activity monitor

* Move GivTCP 'output raw register values' image into images folder

* Move 'Predbat sample data-out dashboard' into images folder

* Added rounding to rate_min_forward_looking log message

* Reformat 'joined Octopus saving session' log & alert for improved readability

* [pre-commit.ci lite] apply automatic fixes

* Expanded and updated Predbat Plan card documentation

* Line length fix

* Minor changes to predbat-plan-card

* Expanded installation guide for #645, clarify Monitor mode

* Added Arg0t's tip to use metric_future_rate_offset_import for more aggressive charging

* Improve battery loss & scaling and weight documentation sections

* New FAQ for improving the plan

* Move configuration docs from config guide to customisation doc

* Completed new FAQ for understanding losses & battery metric #643

* Expanded explanation of how days_previous works #647

* Move extended days_previous examples to separate section

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix issue with charge curve calculation and battery scaling (#671)

* Fix issue with charge curve calculation and battery scaling

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Model use of DC charging from PV with AC grid charger (#675)

* Model use of DC charging from PV with AC grid charger

#669

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Debug output fixes (#676)

* Debug output fixes

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Attempt to fix power curve generation for smaller batteries (#678)

* Support adjustment to existing rates in override (#679)

* Support adjustment to existing rates in override
* Update energy-rates.md

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Automatic charge curve calculation: allow for gaps in battery SOC % (#680)

* Charge curve, allow for gaps in battery SOC %

#666

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Rate scaling divide by 0 protection in charge curve calcuation (#681)

* Automatic unit detected for Watts vs Kwh when reading historical data (#682)

* Automatic unit detected for Watts vs Kwh when reading historical data

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Charge curve averaging and auto mode (#683)

* Charge curve averaging and auto mode

* [pre-commit.ci lite] apply automatic fixes

* Update predbat.py - typo

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix to repeat of incremental rate adjustments (#685)

* Fix to repeat of incremental rate adjustments

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Improve charge curve, and add discharge curve calculations (#690)

* Improve charge curve, and add discharge curve calculations
* Add seperate battery_rate_max_scaling_discharge input entity

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix unit display on input_number (#691)

* Fix unit display on input_number

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Documentation updates (#692)

* Review and update configuration guide

* Review & refine 'what does predbat do'

* Expand explanation days_previous with examples

* Added explanation of how set_reserve_min could be used to retain SOC ahead of predicted storms #571

* Add explanation of using car_charging_energy to filter other loads such as Mixergy out #574

* Add details of load_forecast and predheat Not utilising battery #574

* Added 'choose' branching to givtcp activity monitor

* Added givtcp alert if inverter temperature <5 degrees (should never happen, indicates inverter offline)

* Added GivTCP restart to activity monitor

* Move GivTCP 'output raw register values' image into images folder

* Move 'Predbat sample data-out dashboard' into images folder

* Added rounding to rate_min_forward_looking log message

* Reformat 'joined Octopus saving session' log & alert for improved readability

* [pre-commit.ci lite] apply automatic fixes

* Expanded and updated Predbat Plan card documentation

* Line length fix

* Minor changes to predbat-plan-card

* Expanded installation guide for #645, clarify Monitor mode

* Added Arg0t's tip to use metric_future_rate_offset_import for more aggressive charging

* Improve battery loss & scaling and weight documentation sections

* New FAQ for improving the plan

* Move configuration docs from config guide to customisation doc

* Completed new FAQ for understanding losses & battery metric #643

* Expanded explanation of how days_previous works #647

* Move extended days_previous examples to separate section

* Update configuration-guide.md, add missing predbat_ prefixes

predbat_ prefix missing from a number of entities

* Update energy-rates.md, minor typos

* Update install.mdUpdate install.md, extra highlight of what Monitor mode does

* Update configuration-guide.md, more missing predbat_ prefixes

* Update car-charge-planning.md, clarify settings for Octopus Intelligent

* Typo & formatting corrections

* Create charge curve, more info on entities required for history to create the curve #666

* Added missing predbat_ prefixes to HA entity names

* Expanded predbat freeze charge/discharge statii descriptions #689

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Trefor Southwell <48591903+springfall2008@users.noreply.github.com>

* Update apps.yaml (#694)

* Update apps.yaml

* Update apps-yaml.md - line length fix

* Code cleanup (#656)

* refactor: clean up code for efficiencies and readability

* refactor: clean up code for efficiencies and readability

* refactor: sorted imports

* [pre-commit.ci lite] apply automatic fixes

* refactor: update cspell dict

* refactor: add fstring

* [pre-commit.ci lite] apply automatic fixes

* refactor: cspell dictionary update

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Supporting nordpool format rates (#697)

* Supporting nordpool format rates

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Support multiple files for Predbat internal update feature (#701)

* Support multiple files for Predbat internal update feature

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Auto update fixes (#702)

* Auto update fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Auto update issues (#703)

* Doc strings & some refactoring (#704)

* Doc strings
* Minor refactoing

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Code optimisations (#705)

* Code optimisations

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fix units on calculate plan every (#710)

* Fix units on calculate plan every

#708

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Update settings right away rather than waiting for HA run (#711)

* Update settings right away rather than waiting for HA run

#707

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Add symbols in the plan for different rate sources (#712)

* Add symbols in the plan for different rate sources
* Update predbat-plan-card.md

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Set max charge/discharge rate fuzzy threshold to be max_rate/25 rathe… (#715)

* Set max charge/discharge rate fuzzy threshold to be max_rate/25 rather than fixed at 100

#714

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Show creation time on html plan (#716)

* Show creation time on html plan

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Detect GE inverter in calibration mode, fix to previous charge/discharge rate code (#717)

* Detect GE inverter in calibration mode, fix to previous charge/discharge rate code

#706

* Calibration mode to also reset charge/discharge rate

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Fixes for force selector not changing correctly in all cases (#719)

* Fixes for force selector not changing correctly in all cases

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* Support updates via HA update entity (#721)

#575

* Fixes to predbat update (#722)

#575

* Fix predbat update to show its active (#723)

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Coan <142018870+gcoan@users.noreply.github.com>
Co-authored-by: Steven Marks <marksie1988@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants