Replace Reflections with FastClassPathScanner (#2243) #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalSchumacher
force-pushed
the
replace_reflections_with_fast_classpath_scanner
branch
7 times, most recently
from
2df7a9d
to
35fadb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2346 +/- ##
============================================
+ Coverage 95.07% 95.41% +0.34%
+ Complexity 2979 2956 -23
============================================
Files 339 336 -3
Lines 7917 7858 -59
Branches 642 620 -22
============================================
- Hits 7527 7498 -29
+ Misses 249 227 -22
+ Partials 141 133 -8 |
PascalSchumacher
force-pushed
the
replace_reflections_with_fast_classpath_scanner
branch
from
35fadb1
to
3674dd1
Compare
|
@PascalSchumacher thanks for the PR. Will hold of on pulling this in until we move to 3.0 (breaking change to move to 1.8 jdk) |
PascalSchumacher
force-pushed
the
replace_reflections_with_fast_classpath_scanner
branch
4 times, most recently
from
2835801
to
f952d54
Compare
PascalSchumacher
force-pushed
the
replace_reflections_with_fast_classpath_scanner
branch
from
f952d54
to
7cdbff7
Compare
|
Thank you for the PR! Its been merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.