Added response message examples support (#1570) #2514
Conversation
This reverts commit 1ea0369.
complex cases were Optional.or.Optional and replacing presentInstances FluentIterable.from still used and converted with toJavaUtil()
Need to ensure that Optional setting is correct in Defaults and ParameterRequiredReader Are both java and guava Optional supported?
Blocked tests in FunctionContractSpec and DefaultRequestHandlerCombinerSpec, the fail on command line, work in IDE
still having on and off issues with DefaultRequestHandlerCombinerSpec and FunctionContractSpec
removed another test from FunctionContractSpec
removed more FuctionContractSpec tests
all tests past
Added new 'examples' property to ResponseMessage with corresponding change in ResponseMessageBuilder. Updated corresponding mapping logic, to populate response message examples instead of empty map.
Codecov Report
@@ Coverage Diff @@
## master #2514 +/- ##
============================================
- Coverage 95.08% 95.03% -0.05%
- Complexity 2989 3059 +70
============================================
Files 339 340 +1
Lines 7949 7814 -135
Branches 643 596 -47
============================================
- Hits 7558 7426 -132
+ Misses 251 240 -11
- Partials 140 148 +8 |
Also we use the sorted paths to get a consistent key for the same combination of paths regardless of order (2516) (cherry picked from commit 07a9225538465bc66d23fd2f41edd9ca5db75708)
(2516) (cherry picked from commit ebeb20da28d39ee0e409cad0137fc2e1149ce95e)
(2516)
(1082)
(1082)
Also simplified to use java 8 where possible. (1082)
(2243)
…h_scanner' resolves springfox#2243
|
Hello, @dilipkrish! Any updates on this? |
|
The PR needs conflicts resolved, but I was going pull these in shortly |
|
Any actions required from my (our) side? |
Added new 'examples' property to ResponseMessage with corresponding change in ResponseMessageBuilder. Updated corresponding mapping logic, to populate response message examples instead of empty map.
… into feature/response-examples
|
Seems like I've done it in a wrong way with rebase, sorry for that, it's actually my first PR :| |
|
@q1nt no worries... I'll fix it up. For a first PR 👏 for putting discrete commits and splitting your work into incremental commits. What you probably did there was to not rebase against the origin branch. When I work on PRs I find it easier to understand when I name my upstreams accordingly. For e.g. I usually name |
|
@q1nt thanks for the PR. Sorry I took the easier route than fixing up this PR, which is essentially very similar. |
|
@dilipkrish Is there any chance those changes will be available as part of 2.9.3 version? |
|
No unfortunately, it'll be part of 3.0.0 |
Added new 'examples' property to ResponseMessage with corresponding
change in ResponseMessageBuilder.
Updated corresponding mapping logic, to populate response message
examples instead of an empty map.
It is related to issue #1570 and could be considered as the first step to adding response examples support.