Fixes #2719: Implement support for @NotBlank #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the bots complaint's. Hopefull. |
|
One thing I've also noticed: Why have all the classes @component annotations when they are then declared in a module explicitly (and never picked up by a ComponentScan apparently)? |
Codecov Report
@@ Coverage Diff @@
## master #2720 +/- ##
============================================
+ Coverage 94.77% 94.79% +0.01%
- Complexity 3161 3179 +18
============================================
Files 354 357 +3
Lines 8057 8083 +26
Branches 608 611 +3
============================================
+ Hits 7636 7662 +26
Misses 271 271
Partials 150 150
|
|
Thank you for your PR! one of many!
I believe it started out as a component being scanned and it was better to be explicit. Do you have one in particular. |
hokkun-dayo
reviewed
Apr 23, 2019
| } | ||
|
|
||
| /** | ||
| * read NotNull annotation |
There was a problem hiding this comment.
Thank you for catching that! @hokkun-dayo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initial support for bean validation 2.0 @notblank annotation.
This currently doesn't go beyond the same handling that @NotNull has, but I still split it out into separate plugins because it MIGHT be possible to extend this going forward.
Possible extensions are somehow setting minLength=1 (for strings) / minItems=1 (for collections), but I didn't find an easy way to get this through to the Swagger JSON through Springfox's internal model.
I also copied the unit tests for NotNull and adapted them accordingly.