add support for deprecated controllers #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
============================================
+ Coverage 94.77% 94.77% +<.01%
- Complexity 3161 3163 +2
============================================
Files 354 354
Lines 8057 8059 +2
Branches 608 610 +2
============================================
+ Hits 7636 7638 +2
Misses 271 271
Partials 150 150
|
|
We also need this one. Thanks. |
|
@v3rtumnus thanks for the PR! 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Fixes #2638 and adds support for deprecated controllers
Are there unit tests? If not how should this be manually tested?
Added a test to
OperationCommandReaderSpec.Any background context you want to provide?
The change should be clear by itself I guess.
What are the relevant issues?
#2638