Fix #2855, fix incorrect api parameter type

[dulong]

No description provided.

[codecov]

Codecov Report

Merging #2856 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #2856      +/-   ##
============================================
- Coverage     94.43%   94.42%   -0.02%     
+ Complexity     3226     3225       -1     
============================================
  Files           364      364              
  Lines          8302     8304       +2     
  Branches        619      619              
============================================
+ Hits           7840     7841       +1     
  Misses          304      304              
- Partials        158      159       +1

Impacted Files	Coverage Δ	Complexity Δ
...ing/web/readers/parameter/ParameterTypeReader.java	100% <100%> (ø)	17 <0> (-1)	⬇️
...wagger1/readers/parameter/ParameterNameReader.java	93.33% <66.66%> (-6.67%)	6 <0> (ø)

[codecov]

Codecov Report

Merging #2856 into master will increase coverage by 1.49%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2856      +/-   ##
============================================
+ Coverage     92.93%   94.43%   +1.49%     
+ Complexity     3513     3226     -287     
============================================
  Files           382      364      -18     
  Lines          9330     8304    -1026     
  Branches        768      619     -149     
============================================
- Hits           8671     7842     -829     
+ Misses          471      304     -167     
+ Partials        188      158      -30

Impacted Files	Coverage Δ	Complexity Δ
...wagger1/readers/parameter/ParameterNameReader.java	100% <100%> (ø)	7 <0> (+1)	⬆️
...ing/web/readers/parameter/ParameterTypeReader.java	100% <100%> (ø)	17 <0> (-1)	⬇️
...tation/schema/JaxbPresentInClassPathCondition.java	50% <0%> (-50%)	3% <0%> (+1%)
...s/PropertyDiscriminatorBasedInheritancePlugin.java	88% <0%> (-4.31%)	9% <0%> (-1%)
...ntation/swagger2/web/Swagger2ControllerWebMvc.java	88.46% <0%> (-3.85%)	7% <0%> (-1%)
...documentation/swagger/common/HostNameProvider.java	88.23% <0%> (-1.77%)	4% <0%> (-1%)
...x/documentation/builders/ModelPropertyBuilder.java	94.87% <0%> (-1.62%)	21% <0%> (ø)
...ema/property/OptimizedModelPropertiesProvider.java	97.91% <0%> (-1.51%)	35% <0%> (-8%)
.../documentation/swagger/schema/ApiModelBuilder.java	82.35% <0%> (-0.99%)	5% <0%> (ø)
...ntation/spring/data/rest/SpecificationBuilder.java	92.56% <0%> (-0.92%)	9% <0%> (-6%)
... and 118 more

[dilipkrish]

Mostly looks ok, I feel its introducing a breaking change that will force people to have to annotate @RequestBody. While it fixes your original bug, it breaks existing assumptions.

[dilipkrish]

When will it return a body in this case?

[dilipkrish]

Isnt this incorrect? You're fixing the existing tests by adding this request body. In essence you're not preserving the existing behavior