-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multiple ApiImplicitParameters #3064
Conversation
Thanks for the PR. Unfortunately this PR has a compile error @ileler. Also could you perhaps add a test? |
This PR supercedes #2331 |
get it.However, regarding the test cases, I may have to take a moment to look at it. I am not familiar with the test cases of the project. |
@dilipkrish The test case has been added. |
The build is still failing @ileler It seems like a checkstyle issue |
Codecov Report
@@ Coverage Diff @@
## master #3064 +/- ##
============================================
+ Coverage 92.94% 92.94% +<.01%
- Complexity 3462 3464 +2
============================================
Files 375 375
Lines 9214 9217 +3
Branches 758 760 +2
============================================
+ Hits 8564 8567 +3
+ Misses 464 463 -1
- Partials 186 187 +1
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3064 +/- ##
============================================
+ Coverage 92.94% 92.94% +<.01%
- Complexity 3462 3464 +2
============================================
Files 375 375
Lines 9214 9217 +3
Branches 758 760 +2
============================================
+ Hits 8564 8567 +3
+ Misses 464 463 -1
- Partials 186 187 +1
|
Thank you @ileler! |
What's this PR do/fix?
support multiple ApiImplicitParameters
Are there unit tests? If not how should this be manually tested?
None.
Any background context you want to provide?
What are the relevant issues?
None.