Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple ApiImplicitParameters #3064

Merged
merged 5 commits into from
Aug 6, 2019
Merged

Conversation

kerwin612
Copy link
Contributor

What's this PR do/fix?

support multiple ApiImplicitParameters

Are there unit tests? If not how should this be manually tested?

None.

Any background context you want to provide?

@Target({ ElementType.METHOD, ElementType.ANNOTATION_TYPE, ElementType.TYPE })
@Retention(RetentionPolicy.RUNTIME)
@ApiImplicitParams({
	@ApiImplicitParam(
			name = "common1",
			value = "common1",
			paramType = "header",
			dataType = "String",
			required = true
	),
	@ApiImplicitParam(
			name = "common2",
			value = "common2",
			paramType = "header",
			dataType = "String",
			required = true
	)
})
public @interface ApiImplicitParamsCommon {
}


@ApiImplicitParamsCommon
@ApiImplicitParams({
	@ApiImplicitParam(
			name = "test1",
			value = "test1",
			paramType = "path",
			dataType = "String",
			required = true
	)
})
public void test1(String test1) {}

@ApiImplicitParamsCommon
@ApiImplicitParams({
	@ApiImplicitParam(
			name = "test2",
			value = "test2",
			paramType = "path",
			dataType = "String",
			required = true
	)
})
public void test2(String test2) {}

What are the relevant issues?

None.

@dilipkrish
Copy link
Member

dilipkrish commented Aug 3, 2019

Thanks for the PR. Unfortunately this PR has a compile error @ileler. Also could you perhaps add a test?

@dilipkrish dilipkrish added the PR label Aug 3, 2019
@dilipkrish
Copy link
Member

This PR supercedes #2331

@kerwin612
Copy link
Contributor Author

Thanks for the PR. Unfortunately this PR has a compile error @ileler. Also could you perhaps add a test?

get it.However, regarding the test cases, I may have to take a moment to look at it. I am not familiar with the test cases of the project.

@dilipkrish dilipkrish added this to the 3.0 milestone Aug 4, 2019
@kerwin612
Copy link
Contributor Author

@dilipkrish The test case has been added.

@dilipkrish
Copy link
Member

The build is still failing @ileler It seems like a checkstyle issue

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #3064 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3064      +/-   ##
============================================
+ Coverage     92.94%   92.94%   +<.01%     
- Complexity     3462     3464       +2     
============================================
  Files           375      375              
  Lines          9214     9217       +3     
  Branches        758      760       +2     
============================================
+ Hits           8564     8567       +3     
+ Misses          464      463       -1     
- Partials        186      187       +1
Impacted Files Coverage Δ Complexity Δ
...s/operation/OperationImplicitParametersReader.java 86.66% <66.66%> (-13.34%) 7 <4> (+1)
...umentation/spring/web/scanners/ApiModelReader.java 95.46% <0%> (+0.56%) 88% <0%> (+1%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #3064 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3064      +/-   ##
============================================
+ Coverage     92.94%   92.94%   +<.01%     
- Complexity     3462     3464       +2     
============================================
  Files           375      375              
  Lines          9214     9217       +3     
  Branches        758      760       +2     
============================================
+ Hits           8564     8567       +3     
+ Misses          464      463       -1     
- Partials        186      187       +1
Impacted Files Coverage Δ Complexity Δ
...s/operation/OperationImplicitParametersReader.java 86.66% <66.66%> (-13.34%) 7 <4> (+1)
...umentation/spring/web/scanners/ApiModelReader.java 95.46% <0%> (+0.56%) 88% <0%> (+1%) ⬆️

@dilipkrish dilipkrish merged commit 8ba0627 into springfox:master Aug 6, 2019
@dilipkrish
Copy link
Member

Thank you @ileler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants