Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method sort order (#182 ) #3132

Merged
merged 4 commits into from
Jan 6, 2020
Merged

Fix method sort order (#182 ) #3132

merged 4 commits into from
Jan 6, 2020

Conversation

MaksimOrlov
Copy link
Member

If controller class contains overloaded methods, or methods types with same names it leads to instability of a sort order and influence to output definitions, it changes from run to run.

Spring Data Rest bean names for AssociationAction in some cases can not be defined. In that case Entity class name will be used.

That PR fixes all cases that could lead to instability of definitions.

Fix sort ordering.
@MaksimOrlov MaksimOrlov added the bug label Oct 5, 2019
@MaksimOrlov MaksimOrlov added this to the 3.0 milestone Oct 5, 2019
@MaksimOrlov MaksimOrlov added PR and removed bug labels Oct 5, 2019
Fix checkstyle.
Fix resource listing.
Fix Webflux tests.
@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #3132 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3132      +/-   ##
============================================
+ Coverage     92.91%   92.94%   +0.03%     
- Complexity     3512     3519       +7     
============================================
  Files           382      382              
  Lines          9330     9347      +17     
  Branches        768      768              
============================================
+ Hits           8669     8688      +19     
+ Misses          472      471       -1     
+ Partials        189      188       -1
Impacted Files Coverage Δ Complexity Δ
...ntation/spring/data/rest/SpecificationBuilder.java 93.66% <100%> (+0.18%) 15 <0> (ø) ⬇️
.../documentation/spi/service/contexts/Orderings.java 92.3% <100%> (+5.64%) 19 <10> (+6) ⬆️
...entation/spring/data/rest/ActionSpecification.java 92% <100%> (+0.69%) 11 <1> (ø) ⬇️
...umentation/spring/web/scanners/ApiModelReader.java 95.46% <0%> (+0.56%) 88% <0%> (+1%) ⬆️

@nbv2222
Copy link

nbv2222 commented Nov 5, 2019

should it be merge?

@mikhilvikram
Copy link

When is this likely to be merged?

@goemen
Copy link

goemen commented Jan 3, 2020

Can this ticket be given a higher priority please

@dilipkrish
Copy link
Member

Sorry this took so long @MaksimOrlov!

@dilipkrish dilipkrish merged commit a6a8362 into master Jan 6, 2020
@dilipkrish dilipkrish deleted the bugfix/sort-ordering branch January 6, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants