Bump swagger-ui depdency #3135
Merged
Bump swagger-ui depdency #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security fix detailed in swagger-ui's release notes. https://github.com/swagger-api/swagger-ui/releases/tag/v3.23.11
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
============================================
+ Coverage 92.91% 92.93% +0.02%
- Complexity 3512 3513 +1
============================================
Files 382 382
Lines 9330 9330
Branches 768 768
============================================
+ Hits 8669 8671 +2
+ Misses 472 471 -1
+ Partials 189 188 -1
|
|
@martypitt @dilipkrish @adrianbk, please take a look at this PR that is related to https://nvd.nist.gov/vuln/detail/CVE-2019-17495, a 9.8 critical vulnerability. |
|
@martypitt @dilipkrish @adrianbk can you please take care of this PR? This issue is 9.8 critical vulnerability now and blocking us to use springfox. |
|
I'm also waiting on the merge for this CVE fix, as it's blocking our use of the component. |
|
I'm also waiting on this to be merged as this library is getting flagged in my builds. @martypitt @dilipkrish @adrianbk any chance one of you could take a look at this PR? |
dilipkrish
approved these changes
Jan 6, 2020
|
Thanks @StevenLocke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security fix detailed in swagger-ui's release notes.
https://github.com/swagger-api/swagger-ui/releases/tag/v3.23.11
What's this PR do/fix?
Bumps the swagger-ui dependency.
Are there unit tests? If not how should this be manually tested?
No new functionality, just a gradle dependency version change. All of the old tests should be run to verify no breaking changes between versions.
Any background context you want to provide?
Swagger-ui has a security fix that addresses a CSS-based input field value exfiltration vulnerability in this release.
What are the relevant issues?
#3131