Update swagger ui to version without css security issue #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3226 +/- ##
=========================================
Coverage 92.91% 92.91%
Complexity 3512 3512
=========================================
Files 382 382
Lines 9330 9330
Branches 768 768
=========================================
Hits 8669 8669
Misses 472 472
Partials 189 189 |
dilipkrish
approved these changes
Jan 6, 2020
|
Closes #3193 |
|
Thank you @msbg! |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Primarily updates the version of swagger-ui to the micro update that fixes the css vulnerability.
In addition fixes a failing test when the project is built on windows.
Are there unit tests? If not how should this be manually tested?
No new features - just a dependant version uptick. All existing tests pass.
Any background context you want to provide?
The reason for this update request is that I'm trying to use geode in a project, however that depends on the current release of springfox-swagger-ui. This is being flagged as a security issue due to the use of a vulnerable swagger-ui version. Once this update is included in a versioned build I'll hopefully be doing a similar update to the geode repo.
What are the relevant issues?
This issue was already raised in late November by gokumar:
#3193