Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponseHeader is not working as expected #3374

Closed
dilipkrish opened this issue Jul 8, 2020 · 1 comment
Closed

ResponseHeader is not working as expected #3374

dilipkrish opened this issue Jul 8, 2020 · 1 comment
Labels
Milestone

Comments

@dilipkrish
Copy link
Member

@dilipkrish An update:

I had to replace all dataType = ... with dataTypeClass = ... even for primitive types (so dataType = "double" had to be changed to dataTypeClass = Double.class.

The only issue I can now see is that the description attribute of @ResponseHeader annotation is not being picked up (it was before). So, if I have:

@ResponseHeader(name = HEADER_PAGE_SIZE, response = Integer.class, description = "Number of results per page")

The description no longer appears in the UI. There is no value attribute for this annotation so not sure how to resolve this other than implementing a custom extension. Any idea why this is no longer being picked up?

The real test will be deploying the specification doc to the Google Cloud Endpoint Service - its validation is quite strict.

Originally posted by @andrew-property-xyz in #3360 (comment)

@dilipkrish
Copy link
Member Author

Fixed via #2684

@dilipkrish dilipkrish added this to the 3.0 milestone Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant