Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flow for static type checking #127

Closed
5 tasks done
thibaudcolas opened this issue Dec 23, 2017 · 1 comment · Fixed by #162
Closed
5 tasks done

Add Flow for static type checking #127

thibaudcolas opened this issue Dec 23, 2017 · 1 comment · Fixed by #162
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed
Milestone

Comments

@thibaudcolas
Copy link
Collaborator

thibaudcolas commented Dec 23, 2017

I would love to have Flow set up on this project to check the type of code that's not React components. It is already set up on two related projects, the config & way it runs should be fairly similar:

Rough tasks:

  • Set up flow-bin as a dependency
  • Add .flowconfig based on the one in draftjs-filters
  • Set up in CI
  • Add to Rollup build (strip Flow types)
  • Start by adding types (// @flow and the type annotations) to behavior.js or DraftUtils.js.
@thibaudcolas thibaudcolas added the enhancement New feature or request label Dec 23, 2017
@thibaudcolas thibaudcolas added this to the Post v1.0.0 milestone Dec 23, 2017
@thibaudcolas thibaudcolas added the help wanted Extra attention is needed label Jan 12, 2018
@thibaudcolas thibaudcolas mentioned this issue Sep 24, 2018
14 tasks
@thibaudcolas thibaudcolas reopened this Sep 29, 2018
@thibaudcolas thibaudcolas added good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 2, 2018
thibaudcolas added a commit that referenced this issue Feb 5, 2019
thibaudcolas added a commit that referenced this issue Feb 5, 2019
@thibaudcolas
Copy link
Collaborator Author

Fixed in #178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant