New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flow for static type checking #127

Closed
thibaudcolas opened this Issue Dec 23, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@thibaudcolas
Copy link
Collaborator

thibaudcolas commented Dec 23, 2017

I would love to have Flow set up on this project to check the type of code that's not React components. It is already set up on two related projects, the config & way it runs should be fairly similar:

Rough tasks:

  • Set up flow-bin as a dependency
  • Add .flowconfig based on the one in draftjs-filters
  • Set up in CI
  • Add to Rollup build (strip Flow types)
  • Start by adding types (// @flow and the type annotations) to behavior.js or DraftUtils.js.

@thibaudcolas thibaudcolas added this to the Post v1.0.0 milestone Dec 23, 2017

@thibaudcolas thibaudcolas referenced this issue Sep 24, 2018

Merged

Tooling upgrade #162

14 of 14 tasks complete

@thibaudcolas thibaudcolas reopened this Sep 29, 2018

@thibaudcolas thibaudcolas referenced this issue Jan 7, 2019

Merged

Add Flow for static type checking (#127) #178

6 of 6 tasks complete

thibaudcolas added a commit that referenced this issue Feb 5, 2019

thibaudcolas added a commit that referenced this issue Feb 5, 2019

@thibaudcolas

This comment has been minimized.

Copy link
Collaborator Author

thibaudcolas commented Feb 5, 2019

Fixed in #178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment