-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dependencies compatibility definition, and testing #75
Comments
I reckon it's safer to have an upper bound for both for now as we can always increase it later once we confirm everything is working rather than having to rush a patch.
If you're agree with that I'll update the test-matrix and documentation when I have a moment. Edit: I realize now that the name of the package |
Sounds good! |
lxml 4.0.0 has been released in september and I can confirm 4.1.1 works fine, so I'd suggest going for |
Raised by @loicteixeira in https://github.com/springload/draftjs_exporter/pull/74/files#r135967185. Opening as a separate issue because it's worth discussing and there is no point in holding that PR for this.
At the moment,
draftjs_exporter
defines its dependencies as:draftjs_exporter/setup.py
Lines 15 to 22 in c963514
Those ranges are purposefully big (we want to support as many versions as possible for something as fundamental to people's tech stacks), which is good, but as @loicteixeira puts it then it would make sense to test accordingly, with the lower and upper bounds at least.
More info to help in the decision,
setup.py
to limit installed versions to below 4.0.0?Finally, bear in mind that our usage of the APIs of those dependencies is very small (HTML string -> DOM nodes conversion, DOM nodes -> HTML string conversion, create nodes, append child to node), which means that the potential breakage would only likely be in how those engines handle specific content, which is hard to test for. We do however have a small test suite of "potential engine quirks": https://github.com/springload/draftjs_exporter/blob/master/tests/engines/test_engines_differences.py
The text was updated successfully, but these errors were encountered: