Merge pull request #273 from springload/fix/render-issues

fix(Accordion): use the hidden attribute
springload · Jul 2, 2020 · 6e20760 · 6e20760
2 parents 0a1716d + a7dd9c9
commit 6e20760
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 16 deletions.
diff --git a/integration/__snapshots__/wai-aria.spec.js.snap b/integration/__snapshots__/wai-aria.spec.js.snap
@@ -7,26 +7,14 @@ Object {
       "name": "Heading One",
       "role": "button",
     },
-    Object {
-      "name": "Sunt in reprehenderit cillum ex proident qui culpa fugiat pariatur aliqua nostrud consequat consequat enim quis sit consectetur ad aute ea ex eiusmod id esse culpa et pariatur ad amet pariatur pariatur dolor quis.",
-      "role": "text",
-    },
     Object {
       "name": "Heading Two",
       "role": "button",
     },
-    Object {
-      "name": "Velit tempor dolore commodo voluptate id do nulla do ut proident cillum ad cillum voluptate deserunt fugiat ut sed cupidatat ut consectetur consequat incididunt sed in culpa do labore ea incididunt ea in eiusmod.",
-      "role": "text",
-    },
     Object {
       "name": "Heading Three",
       "role": "button",
     },
-    Object {
-      "name": "Lorem ipsum esse occaecat voluptate duis incididunt amet eiusmod sunt commodo sunt enim anim ea culpa ut tempor dolore fugiat exercitation aliquip commodo dolore elit esse est ullamco velit et deserunt.",
-      "role": "text",
-    },
   ],
   "name": "React Accessible Accordion - Integration Test Sandbox",
   "role": "WebArea",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "react-accessible-accordion",
-    "version": "3.1.0",
+    "version": "3.1.1",
     "description": "Accessible Accordion component for React",
     "main": "dist/umd/index.js",
     "module": "dist/es/index.js",

diff --git a/src/css/fancy-example.css b/src/css/fancy-example.css
@@ -42,7 +42,7 @@
     transform: rotate(45deg);
 }
 
-.accordion *[data-hidden] {
+[hidden] {
     display: none;
 }
 

diff --git a/src/helpers/AccordionStore.ts b/src/helpers/AccordionStore.ts
@@ -5,7 +5,7 @@ export interface InjectedPanelAttributes {
     'aria-hidden': boolean | undefined;
     'aria-labelledby': string;
     id: string;
-    'data-hidden': boolean | undefined;
+    hidden: boolean | undefined;
 }
 
 export interface InjectedHeadingAttributes {
@@ -92,7 +92,7 @@ export default class AccordionStore {
             'aria-hidden': this.allowMultipleExpanded ? !expanded : undefined,
             'aria-labelledby': this.getButtonId(uuid),
             id: this.getPanelId(uuid),
-            'data-hidden': expanded ? undefined : true,
+            hidden: expanded ? undefined : true,
         };
     };