Chore/accordion item title refactor #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng' item from store.
…g all the 'find' logic to the wrapper
ryami333
commented
Jun 6, 2018
|
|
||
| setExpanded(key: string | number, expanded: boolean) { | ||
| return this.setState(state => ({ | ||
| setExpanded = (key: string | number, expanded: boolean) => |
There was a problem hiding this comment.
Ran into a javascript context issue where this didn't equal what I wanted it to equal, so using arrow functions here to bind the correct context.
vincentaudebert
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An effort to shift all of the store/container logic to the 'wrapper' and let the 'dumb' component deal only with UI and interaction. So basically, the wrapper passes it all of the props that it needs, no more, no less.
Does not require a release because there is no user-land changes.
Will move on to accordion-item-body