Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/typescript #141

Merged
merged 59 commits into from
Jan 14, 2019
Merged

Chore/typescript #141

merged 59 commits into from
Jan 14, 2019

Conversation

ryami333
Copy link
Contributor

@ryami333 ryami333 commented Jan 3, 2019 •
edited
Loading

Migrating from Flow to Typescript. OK to merge to master without a release/documentation because I plan on making a couple of other breaking changes before making a 'major' release :)

Notes:

  • Consecutive did not have types available, so simply wrote that into its own helper utility.
  • Recompose typing was hell (as is most HOC typing) so removed it in favour of a more bare-metal approach.
  • Big fan of tslint-microsoft-contrib. Quite strict and opinionated, but the best third-party plugin/preset I've found for tslint.
  • The huge diffs in spec files are not meaningful - they're mostly just to fix typing assertions. There are a handful of new tests, but no test assertions have been meaningfully modified.

@coveralls
Copy link

coveralls commented Jan 3, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 99.425% when pulling 6537261 on chore/typescript into 604ecfb on master.

@ryami333 ryami333 force-pushed the chore/typescript branch 2 times, most recently from 285bcf7 to 9843c8e Compare January 3, 2019 22:12
@ryami333 ryami333 requested a review from holloway January 7, 2019 22:24
@ryami333
Replace '@babel/preset-flow' with '@babel/preset-typescript'
bfacf65
@ryami333
Remove @flow annotations
ab968a4
@ryami333
Install typescript and types
c63fd9f
@ryami333
Convert Accordion to TS
1bb04aa
@ryami333
Convert Accordion.wrapper to TS
c044229
@ryami333
Do typecheck in lint-staged
ad56318
@ryami333
Convert AccordionContainer to TS
4592861
@ryami333
Convert AccordionContainer.spec to TS
6cb61a0
@ryami333
Convert AccordionItem to TS
26fad9a
@ryami333
Convert AccordionItem.spec to TS
fedaa88
@ryami333
Remove unused type
34ba5f1
@ryami333
Refactor ItemContainer to TS
b88251f
@ryami333
Configure jest to deal with TS tests
8f601d8
@ryami333
Create 'CombineConsumers' helper class
d3fe247
@ryami333
Fix React import in CombineConsumers spec
9cad0a2
@ryami333
Refactor AccordionItemTitle to tsx
d09a5e8
@ryami333
Add 'getItemStore' and 'getAccordionStore' helpers to ItemContainer a…
d47a64e 
…nd AccordionContainer to avoid HOC composition.
@ryami333
Convert AccordionItem.wrapper to tsx
3ea6d06
@ryami333
Convert AccordionItemTitle.wrapper to tsx
239e054
@ryami333
Refactor AccordionItemBody (and wrapper) to tsx
bf8ee86
@ryami333
Export 'contextTypes' from AccordionContainer and ItemContainer, and …
485e66f 
…add unit tests to test it (and 'getFooStore' methods)
@ryami333
Use contextTypes throughout wrapper components
1208232
@ryami333
Remove unused import
eab3c94
@ryami333
Refactor AccordionItemTitle.spec to TSX
ce19417
@ryami333
Update snapshots
04ace50
@ryami333
Remove eslint and flow dependencies (and configs)
31aa51b
@ryami333
Add tslint with prettier configs
b218e3f
@ryami333
Add a lint task
a6233be
@ryami333
Fix linting errors and reinstate linting commit hooks
7438c87
@ryami333
Add typecheck task
a96f4e9
@ryami333
Add a build:types step
b4ddcae
@ryami333
Explicitly type AccordionContainers@contextTypes to fix TS errors
3f545e3
@ryami333
Use CONTEXT_KEY explicitly in wrapper components
aeaf454
@ryami333
Add tslint-react
ad6ff4d
@ryami333
Fix context in AccordionContainer and ItemContainer
7791cc5
@ryami333
Create a 'uuid' helper file
66f5cd2
@ryami333
Install tslint-microsoft-contrib and refactor to fix all linting and …
f4c55f7 
…ts errors
@ryami333
Add typing to all arrow-function call signatures
5009893
@ryami333
Add typing to arrow-function parameters
4fc29b3
@ryami333
Fix rollup entrypoint name
be8fd25
@ryami333
Bump rollup and deps
096e8a6
@ryami333
Configure TS extensions with rollup config
1a80978
@ryami333
Add tsconfig/tslint.json to npm ignores.
e28e8df
@ryami333
Add tests to address drop in coverage
774cc0b
@ryami333
Remove redundant todo
61a8cd4
@ryami333
Add console.error when components are not nested appropriately.
43b686e
@ryami333
Add test to ensure AccordionItemBody does not render without accordio…
4846e46 
…nStore and itemStore in context
@ryami333
Make propTypes wildcard more dry by moving it to helpers file
feb34fd
@ryami333
Add unit tests for propTypes helper
60a0d17
@ryami333 ryami333 merged commit d7c32c8 into master Jan 14, 2019
@ryami333 ryami333 deleted the chore/typescript branch January 14, 2019 20:07
@ryami333 ryami333 mentioned this pull request Jan 16, 2019
Closed
@FriOne
Copy link

FriOne commented Feb 7, 2019

@ryami333 hi! Could you say when the next major version be released?
I found this awesome module at the wrong time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holloway holloway Awaiting requested review from holloway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryami333 @coveralls @FriOne