Added support for non-strict unordered assertion mode. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
springtestdbunit » spring-test-dbunit #28 FAILURE |
|
Maybe we could make this to be the default behavior of NON_STRICT mode? |
|
either way, unordered non-strict comparison is a must and should be implemented/merged as soon as possible. |
philwebb
added a commit
that referenced
this pull request
Sep 17, 2014
* non-strict-unordered-assertion: Add DatabaseAssertionMode.NON_STRICT_UNORDERED
|
Merged with a few tweaks. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new mode "NON_STRICT_UNORDERED" to DatabaseAssertionMode enum to be able to compare actual and expected data ignoring order of rows. Corresponding class to this mode sorts two data sets using SortedTable.
When using only NON_STRICT mode, our test cases pass sometimes but fails sometimes because the order of actual data can not match expected data every time so we need to this behaviour.