feat: Added @AsyncMessage #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for springwolf-ui canceled.
|
timonback
reviewed
Jun 24, 2023
...shamir/springwolf/asyncapi/scanners/channels/operationdata/AbstractOperationDataScanner.java
Outdated
Show resolved
Hide resolved
timonback
reviewed
Jun 24, 2023
...shamir/springwolf/asyncapi/scanners/channels/operationdata/AbstractOperationDataScanner.java
Outdated
Show resolved
Hide resolved
timonback
reviewed
Jun 24, 2023
...shamir/springwolf/asyncapi/scanners/channels/operationdata/AbstractOperationDataScanner.java
Show resolved
Hide resolved
timonback
reviewed
Jun 24, 2023
...n/java/io/github/stavshamir/springwolf/asyncapi/types/channel/operation/message/Message.java
Show resolved
Hide resolved
timonback
reviewed
Jun 24, 2023
.../asyncapi/scanners/channels/operationdata/annotation/AsyncListenerAnnotationScannerTest.java
Outdated
Show resolved
Hide resolved
|
I like the addition and believe it is a benefit for our users. |
ctasada
force-pushed
the
ctasada/add-asyncmessage
branch
2 times, most recently
from
de9a6a9
to
c00d77f
Compare
timonback
reviewed
Jun 30, 2023
...shamir/springwolf/asyncapi/scanners/channels/operationdata/AbstractOperationDataScanner.java
Outdated
Show resolved
Hide resolved
sam0r040
requested changes
Jun 30, 2023
...ringwolf/asyncapi/scanners/channels/operationdata/annotation/AsyncAnnotationScannerUtil.java
Show resolved
Hide resolved
.../asyncapi/scanners/channels/operationdata/annotation/AsyncListenerAnnotationScannerTest.java
Show resolved
Hide resolved
ctasada
force-pushed
the
ctasada/add-asyncmessage
branch
2 times, most recently
from
90b7f86
to
39098ad
Compare
Added support for a new `@AsyncMessage` annotation. This annotation can be used as a method parameter annotation on the same method the `@AsyncPublisher` or `@AsyncListener` annotations are used. This new `@AsyncMessage` annotation allows to enrich the AsyncAPI Operation Message with all the supported fields. The Message payload documentation stays in the Swagger `@Schema` annotation. This new `@AsyncMessage` annotation is intended to enrich the missing values. A special case is the description, which is available in both. Any value defined in `@AsyncMessage` has higher priority than any other default value.
ctasada
force-pushed
the
ctasada/add-asyncmessage
branch
from
39098ad
to
0bbaff8
Compare
Following the spec https://www.asyncapi.com/docs/reference/specification/v2.6.0#operationObject the `message` value should be part of the operationObject.
timonback
reviewed
Jul 3, 2023
...shamir/springwolf/asyncapi/scanners/channels/operationdata/AbstractOperationDataScanner.java
Outdated
Show resolved
Hide resolved
timonback
reviewed
Jul 3, 2023
...shamir/springwolf/asyncapi/scanners/channels/operationdata/AbstractOperationDataScanner.java
Outdated
Show resolved
Hide resolved
timonback
approved these changes
Jul 3, 2023
sam0r040
approved these changes
Jul 7, 2023
|
Great addition and thank you for the review cycles. Looking forward to release this soon and supporting more AsyncApi features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for a new
@AsyncMessageannotation. This annotation can be used as a method parameter annotation on the same method the@AsyncPublisheror@AsyncListenerannotations are used.This new
@AsyncMessageannotation allows to enrich the AsyncAPI Operation Message with all the supported fields.The Message payload documentation stays in the Swagger
@Schemaannotation. This new@AsyncMessageannotation is intended to enrich the missing values.A special case is the description, which is available in both. Any value defined in
@AsyncMessagehas higher priority than any other default value.