Defer fail-fast initialization to ApplicationReadyEvent #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a small change to the fail-fast initialization of AsyncApi. Until now, the initialization happend during
afterPropertiesSet()
method inSpringWolfInitApplicationListener
- which means: after theSpringWolfInitApplicationListener
bean and all dependents (includingAsyncApiService
etc...) have been initialized.The disadvantage of initializing the AsyncAPI at this point of time is, that the spring context isn't completly initialized, some beans may not exist in the spring-context at this moment. This may be problematic if scanner classes will for example make use of
BeanPostProcessors
or Spring AOP to detect (infrastructre) beans.I moved the fail-fast initializing branch into the
onApplicationEvent()
method, which means: