Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for UI components #692

Merged
merged 12 commits into from Apr 12, 2024

Conversation

aerfus
Copy link
Contributor

@aerfus aerfus commented Apr 8, 2024

Test coverage for

  • channel-main.component
  • channels.component
  • header.component
  • info.component
  • schema.component
  • schemas.component
  • servers.component

Resolves #378

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for springwolf-ui ready!

Name Link
🔨 Latest commit ffcc6e0
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/6613f72e1e5b3000082797a1
😎 Deploy Preview https://deploy-preview-692--springwolf-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Material components are mentioned in the wrong section

Refs springwolf#378
@sam0r040 sam0r040 merged commit 2914e81 into springwolf:master Apr 12, 2024
20 checks passed
@sam0r040
Copy link
Collaborator

@aerfus Really cool that you started with component testing for the ui. This is a great starting point for catching regressions.
Have you considered validating the displayed data on the page as well? (i.e. it actually shows the correct message description)

@aerfus
Copy link
Contributor Author

aerfus commented Apr 13, 2024

Hi @sam0r040 ,
yes, those are basic tests. I was planning to add more coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add More Spec Details to the UI
3 participants