test: use angular testing library for component tests #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timonback
commented
Apr 28, 2024
•
timonback
commented
- refactored 3 test as a start
- testing with actual (amqp) mock data (can be extended later)
- refactored 3 test as a start - testing with actual (amqp) mock data
✅ Deploy Preview for springwolf-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @aerfus Feel free to have a look and review. I am curious about your thoughts. |
|
Hi @timonback , In general I agree with the refactoring. Look nice! |
Great, I am curious. @aerfus can you publish/comment your review. I cant see your comments yet. Do your comments still have the 'pending' tag? |
aerfus
suggested changes
May 2, 2024
springwolf-ui/src/app/components/channels/channels.component.spec.ts
Outdated
Show resolved
Hide resolved
springwolf-ui/src/app/components/channels/channel-main/channel-main.component.spec.ts
Outdated
Show resolved
Hide resolved
aerfus
approved these changes
May 3, 2024
aerfus
approved these changes
May 3, 2024
timonback
force-pushed
the
test/springwolf-ui-angular-testing-library
branch
from
feb2388
to
4699705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.