Merge pull request #38 from nvllsvm/link

Change HTTPResponse.links to return empty list when Link header is not present
sprockets · Sep 15, 2021 · 19d4bd5 · 19d4bd5
2 parents 3e1e1e4 + 5324f7d
commit 19d4bd5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/docs/history.rst b/docs/history.rst
@@ -1,6 +1,10 @@
 Version History
 ===============
 
+Next
+----
+- Change ``HTTPResponse.links`` to return empty list when ``Link`` header is not present
+
 `2.4.1`_ Nov 30 2020
 --------------------
 - Make request retry timeout configurable

diff --git a/sprockets/mixins/http/__init__.py b/sprockets/mixins/http/__init__.py
@@ -152,13 +152,13 @@ def links(self):
         """
         if not self._responses:
             return None
+        links = []
         if 'Link' in self._responses[-1].headers:
-            links = []
             for l in headers.parse_link(self._responses[-1].headers['Link']):
                 link = {'target': l.target}
                 link.update({k: v for (k, v) in l.parameters})
                 links.append(link)
-            return links
+        return links
 
     @property
     def ok(self):

diff --git a/tests.py b/tests.py
@@ -258,7 +258,7 @@ def test_get(self):
             'foo': ['bar'],
             'status_code': ['200']
         })
-        self.assertIsNone(response.links)
+        self.assertEqual(response.links, [])
 
     @testing.gen_test
     def test_post(self):