Wrap status_code as a string

sprockets · Sep 2, 2014 · c605621 · c605621
1 parent fb43d6a
commit c605621
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/setup.py b/setup.py
@@ -29,7 +29,7 @@ def read_requirements_file(req_name):
 
 setuptools.setup(
     name='sprockets.mixins.statsd',
-    version='1.0.2',
+    version='1.0.3',
     description='Handler mixins for automated metric reporting',
     long_description=codecs.open('README.rst', encoding='utf-8').read(),
     url='https://github.com/sprockets/sprockets.mixins.statsd.git',

diff --git a/sprockets/mixins/statsd/__init__.py b/sprockets/mixins/statsd/__init__.py
@@ -39,7 +39,7 @@ def get(self, *args, **kwargs):
 
 from sprockets.clients import statsd
 
-version_info = (1, 0, 2)
+version_info = (1, 0, 3)
 __version__ = '.'.join(str(v) for v in version_info)
 
 STATSD_PREFIX = os.getenv('STATSD_PREFIX', 'sprockets')
@@ -73,12 +73,12 @@ def on_finish(self):
                               self.__module__,
                               self.__class__.__name__,
                               self.request.method,
-                              self._status_code,
+                              str(self._status_code),
                               value=self.request.request_time() * 1000)
             statsd.incr(STATSD_PREFIX,
                         'counters',
                         self.__module__,
                         self.__class__.__name__,
                         self.request.method,
-                        self._status_code)
+                        str(self._status_code))
         super(RequestMetricsMixin, self).on_finish()
diff --git a/tests.py b/tests.py
@@ -49,12 +49,13 @@ def test_on_finish_calls_statsd_add_timing(self, incr, add_timing):
         self.duration = self.request._finish_time - self.request._start_time
         self.handler.on_finish()
         add_timing.assert_called_once_with('sprockets', 'timers', 'tests',
-                                           'StatsdRequestHandler', 'GET', 200,
+                                           'StatsdRequestHandler', 'GET',
+                                           '200',
                                            value=self.duration * 1000)
 
     @mock.patch('sprockets.clients.statsd.add_timing')
     @mock.patch('sprockets.clients.statsd.incr')
     def test_on_finish_calls_statsd_incr(self, incr, add_timing):
         self.handler.on_finish()
         incr.assert_called_once_with('sprockets', 'counters', 'tests',
-                                     'StatsdRequestHandler', 'GET', 200)
+                                     'StatsdRequestHandler', 'GET', '200')