Resolved issue with removeObserver and @each #541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a patch for an issue I was running into when adding and removing content observers at runtime. I would start out by adding an observer for something like
@each.name
and then later on replace it with one on@each.age
.The problem is that SC._ChainObserver.destroyChain doesn't remove content observers, so when I removed the
@each.name
observer,"name"
would still be in the_kvo_content_observed_keys
set, and when I then added the@each.age
observer,_setupContentObservers
would loop through those keys and find"name"
, even though the observer itself had been set to null. It would then call_resumeChainObservingForItemWithChainObserver
and pass in null as the second argument (observer
), which would throw an error because it would try to accessobserver.property
.To fix this I added a special case for
@each
in destroyChain, which calls_removeContentObserver
on the object. Tests are included.