Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Changelog with changes since v0.1.0 #123

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Update Changelog with changes since v0.1.0 #123

merged 1 commit into from
Apr 2, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 24, 2021

Prepare for v0.2.0 release: #119

See also: ssi Changelog updates spruceid/ssi#143

@clehner clehner mentioned this pull request Mar 24, 2021
Closed
12 tasks
sbihel
sbihel approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify did:tz layers 2 & 3. And for WASM maybe say that enabling HTTP brings the features to parity with the other platforms?

@clehner
Copy link
Contributor Author

clehner commented Mar 29, 2021

did:tz layers 2 & 3

I think this would be covered by the ssi changelog:
spruceid/ssi@1ecb3d9#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR30
Or were there changes in didkit specifically for this?

I've added a link now to ssi's changes, including its updated changelog. When we have a tagged release we could link to that instead of the GitHub compare changes page. Also updated the ssi CI ref to match.

enabling HTTP brings the features to parity with the other platforms?

Updated.

Changes rebased onto latest main.

@sbihel
Copy link
Member

sbihel commented Mar 29, 2021

Or were there changes in didkit specifically for this?

No, I was just thinking in case someone is lazy and only looking at the changelog for DIDKit they might miss some things, but the link to the ssi changelog is more elegant 👍

@wyc wyc self-requested a review April 2, 2021 17:17
@clehner
Copy link
Contributor Author

clehner commented Apr 2, 2021

Updated since #125 #115 #117 were merged

@clehner
Copy link
Contributor Author

clehner commented Apr 2, 2021

Rebased

@clehner clehner merged commit 61cbc9a into main Apr 2, 2021
@clehner clehner deleted the fix/changelog branch April 2, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyc wyc wyc approved these changes

@sbihel sbihel sbihel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clehner @sbihel @wyc