Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude didkit-wasm in build instructions #62

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Exclude didkit-wasm in build instructions #62

merged 1 commit into from
Feb 9, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Feb 8, 2021

cargo build in the repo root directory builds all the packages in the workspace. Since #55 this results in enabling conflicting features for cryptographic backends in ssi. This PR updates the readme to say to build the workspace excluding the didkit-wasm crate - so that the ssi features needed for WASM (which conflict with the default ssi features) are not enabled at the same time.

I'm also open to suggestions on other ways to make this better.

didkit-wasm depends on ssi features that conflict with features used
by the other packages.
@wyc wyc merged commit de2e0cd into main Feb 9, 2021
@wyc wyc deleted the exclude-wasm branch February 9, 2021 12:57
@theosirian
Copy link
Collaborator

We could add default-members = [...] to the workspace configuration excluding WASM by default, so cargo build can still be run without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants