Cacao-zcap SDK support. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the core SDK functionality into rust. - Extract some common Kepler lib code into a different crate. - Support for CacaoZcap2022 in the SDK. - Support for #host delegations in the SDK.
- Expand capabilityChain at each level to include the full chain, rather than just the parent. - Express the invocationTarget and root zcap as separate resources in the delegation resource list.
chunningham
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
overall LGTM, in future we can think about what else we can move into Kepler-lib, but this works well, is pretty clean and does all we need. is the typescript type declaration in sdk-wasm::host something we can extend to all fns/does it generate typed TS fns on the other side? I wouldn't think so but I live in hope
- Don't use ring for anything. - Add documented ts types for the wasm boundary types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister kepler-sdk PR: spruceid/kepler-sdk#40