Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/car streams #142

Draft
wants to merge 7 commits into
base: feat/p2p-checkpoint
Choose a base branch
from
Draft

Feat/car streams #142

wants to merge 7 commits into from

Conversation

chunningham
Copy link
Member

Description

Implements carv1 and v2 formats in a streaming fashion, to and from implementers of AsyncWrite and AsyncRead. Both v1 and v2 are implemented as v2 extends v1. It's main functions are write_carv1 for writing a stream of blocks into an AsyncWrite and stream_carv1 for converting an AsyncRead into a stream of blocks. the CarV2 impl still needs some implementation for doing the offsets and index.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Diligence Checklist

(Please delete options that are not relevant)

  • This change requires a documentation update
  • I have included unit tests
  • I have updated and/or included new integration tests
  • I have updated and/or included new end-to-end tests
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chunningham chunningham changed the base branch from main to feat/p2p-checkpoint April 28, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant