Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Prototype POAP Flow to Rebase #45

Merged
merged 1 commit into from Feb 20, 2023
Merged

Conversation

krhoda
Copy link
Contributor

@krhoda krhoda commented Feb 16, 2023

Description

Adds prototype POAP Flow.

Type

  • New feature (non-breaking change which adds functionality)

Diligence Checklist

(Please delete options that are not relevant)

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ffd3b7
Status: ✅  Deploy successful!
Preview URL: https://cfe88552.rebase.pages.dev
Branch Preview URL: https://feat-poap-ownership-prototyp.rebase.pages.dev

View logs

@krhoda krhoda force-pushed the feat/poap-ownership-prototype branch from d0e6a49 to eb47f10 Compare February 17, 2023 21:17
@krhoda krhoda changed the title [WIP] Adds Prototype POAP Flow to Rebase Adds Prototype POAP Flow to Rebase Feb 17, 2023
@krhoda krhoda force-pushed the feat/poap-ownership-prototype branch from eb47f10 to c247192 Compare February 17, 2023 21:40
Updates witness_sdk and witness to include POAP flow

Makes error handling more consistent, more updates in forthcoming PR

Updates docs to mention POAP Flow, explains it isn't prod ready
rust/rebase/src/flow/poap_ownership.rs Show resolved Hide resolved
rust/rebase/src/flow/poap_ownership.rs Show resolved Hide resolved
Copy link
Member

@chunningham chunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpicks, looks really good 👍

demo/witness/worker/worker.js Show resolved Hide resolved
rust/rebase/src/flow/poap_ownership.rs Show resolved Hide resolved
@krhoda krhoda merged commit 7de814d into main Feb 20, 2023
@krhoda krhoda deleted the feat/poap-ownership-prototype branch June 14, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants